tracing: get rid of files in TracingController interface

chrome/test/base/tracing.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/base/tracing.h"
 
 #include "base/debug/trace_event.h"
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
 #include "base/memory/singleton.h"
 #include "base/message_loop/message_loop.h"
 #include "base/strings/string_util.h"
 #include "base/timer/timer.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/tracing_controller.h"
 #include "content/public/test/test_utils.h"
 
 namespace {
 
 using content::BrowserThread;
 
+class StringTraceSink : public content::TracingController::TraceDataSink {
+ public:
+  StringTraceSink(std::string* result, const base::Closure& callback)
+      : result_(result), completion_callback_(callback) {}
+
+  virtual void AddTraceChunk(const std::string& chunk) OVERRIDE {
+    *result_ += result_->empty() ? "[" : ",";
+    *result_ += chunk;
+  }
+  virtual void Close() OVERRIDE {
+    if (!result_->empty())
+      *result_ += "]";
+    completion_callback_.Run();
+  }
+
+ private:
+  virtual ~StringTraceSink() {}
+
+  std::string* result_;
+  base::Closure completion_callback_;
+
+  DISALLOW_COPY_AND_ASSIGN(StringTraceSink);
+};
+
 class InProcessTraceController {
  public:
   static InProcessTraceController* GetInstance() {
     return Singleton<InProcessTraceController>::get();
   }
 
   InProcessTraceController()
       : is_waiting_on_watch_(false),
         watch_notification_count_(0) {}
   virtual ~InProcessTraceController() {}
@@ skipping 48 matching lines @@
     is_waiting_on_watch_ = false;
 
     return watch_notification_count_ == 0;
   }
 
   bool EndTracing(std::string* json_trace_output) {
     DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
     using namespace base::debug;
 
     if (!content::TracingController::GetInstance()->DisableRecording(
-        base::FilePath(),
-        base::Bind(&InProcessTraceController::OnTraceDataCollected,
-                   base::Unretained(this),
-                   base::Unretained(json_trace_output))))
+            new StringTraceSink(
+                json_trace_output,
+                base::Bind(&InProcessTraceController::OnTracingComplete,
+                           base::Unretained(this))))) {
       return false;
-
+    }
     // Wait for OnEndTracingComplete() to quit the message loop.
     message_loop_runner_ = new content::MessageLoopRunner;
     message_loop_runner_->Run();
 
     // Watch notifications can occur during this method's message loop run, but
     // not after, so clear them here.
     watch_notification_count_ = 0;
     return true;
   }
 
  private:
   friend struct DefaultSingletonTraits<InProcessTraceController>;
 
   void OnEnableTracingComplete() {
     message_loop_runner_->Quit();
   }
 
-  void OnEndTracingComplete() {
-    message_loop_runner_->Quit();
-  }
-
-  void OnTraceDataCollected(std::string* json_trace_output,
-                            const base::FilePath& path) {
-    BrowserThread::PostTask(BrowserThread::FILE, FROM_HERE,
-        base::Bind(&InProcessTraceController::ReadTraceData,
-                   base::Unretained(this),
-                   base::Unretained(json_trace_output),
-                   path));
-  }
-
-  void ReadTraceData(std::string* json_trace_output,
-                     const base::FilePath& path) {
-    json_trace_output->clear();
-    bool ok = base::ReadFileToString(path, json_trace_output);
-    DCHECK(ok);
-    base::DeleteFile(path, false);
-
-    // The callers expect an array of trace events.
-    const char* preamble = "{\"traceEvents\": ";
-    const char* trailout = "}";
-    DCHECK(StartsWithASCII(*json_trace_output, preamble, true));
-    DCHECK(EndsWith(*json_trace_output, trailout, true));
-    json_trace_output->erase(0, strlen(preamble));
-    json_trace_output->erase(json_trace_output->end() - 1);
-
-    BrowserThread::PostTask(BrowserThread::UI, FROM_HERE,
-        base::Bind(&InProcessTraceController::OnEndTracingComplete,
-                   base::Unretained(this)));
-  }
+  void OnTracingComplete() { message_loop_runner_->Quit(); }
 
   void OnWatchEventMatched() {
     if (watch_notification_count_ == 0)
       return;
     if (--watch_notification_count_ == 0) {
       timer_.Stop();
       if (is_waiting_on_watch_)
         message_loop_runner_->Quit();
     }
   }
@@ skipping 33 matching lines @@
 bool WaitForWatchEvent(base::TimeDelta timeout) {
   return InProcessTraceController::GetInstance()->WaitForWatchEvent(timeout);
 }
 
 bool EndTracing(std::string* json_trace_output) {
   return InProcessTraceController::GetInstance()->EndTracing(json_trace_output);
 }
 
 }  // namespace tracing