Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(985)

Unified Diff: extensions/browser/api/web_view/web_view_internal_api.h

Issue 541753004: Split web_view_internal_api and move part of it to extensions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/web_view/web_view_internal_api.h
diff --git a/chrome/browser/extensions/api/web_view/web_view_internal_api.h b/extensions/browser/api/web_view/web_view_internal_api.h
similarity index 78%
rename from chrome/browser/extensions/api/web_view/web_view_internal_api.h
rename to extensions/browser/api/web_view/web_view_internal_api.h
index cef54351c04308be400d562a7cbd914767dfa2d7..ff9986e7e47d5a1b8e41b4177de8beb81d056784 100644
--- a/chrome/browser/extensions/api/web_view/web_view_internal_api.h
+++ b/extensions/browser/api/web_view/web_view_internal_api.h
@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CHROME_BROWSER_EXTENSIONS_API_WEB_VIEW_WEB_VIEW_INTERNAL_API_H_
-#define CHROME_BROWSER_EXTENSIONS_API_WEB_VIEW_WEB_VIEW_INTERNAL_API_H_
+#ifndef EXTENSIONS_BROWSER_API_WEB_VIEW_WEB_VIEW_INTERNAL_API_H_
+#define EXTENSIONS_BROWSER_API_WEB_VIEW_WEB_VIEW_INTERNAL_API_H_
#include "extensions/browser/api/capture_web_contents_function.h"
#include "extensions/browser/api/execute_code_function.h"
@@ -14,8 +14,6 @@
// new APIs must extend WebViewInternalExtensionFunction or
// WebViewInternalExecuteCodeFunction which do a process ID check to prevent
// abuse by normal renderer processes.
-// TODO(guohui): refactor WebViewInternalExecuteCodeFunction to also extend
-// WebViewInternalExtensionFunction.
namespace extensions {
// An abstract base class for async webview APIs. It does a process ID check
@@ -35,74 +33,6 @@ class WebViewInternalExtensionFunction : public AsyncExtensionFunction {
virtual bool RunAsyncSafe(WebViewGuest* guest) = 0;
};
-class WebViewInternalContextMenusCreateFunction
- : public AsyncExtensionFunction {
- public:
- DECLARE_EXTENSION_FUNCTION("webViewInternal.contextMenusCreate",
- WEBVIEWINTERNAL_CONTEXTMENUSCREATE);
- WebViewInternalContextMenusCreateFunction() {}
-
- protected:
- virtual ~WebViewInternalContextMenusCreateFunction() {}
-
- // ExtensionFunction implementation.
- virtual bool RunAsync() OVERRIDE;
-
- private:
- DISALLOW_COPY_AND_ASSIGN(WebViewInternalContextMenusCreateFunction);
-};
-
-class WebViewInternalContextMenusUpdateFunction
- : public AsyncExtensionFunction {
- public:
- DECLARE_EXTENSION_FUNCTION("webViewInternal.contextMenusUpdate",
- WEBVIEWINTERNAL_CONTEXTMENUSUPDATE);
- WebViewInternalContextMenusUpdateFunction() {}
-
- protected:
- virtual ~WebViewInternalContextMenusUpdateFunction() {}
-
- // ExtensionFunction implementation.
- virtual bool RunAsync() OVERRIDE;
-
- private:
- DISALLOW_COPY_AND_ASSIGN(WebViewInternalContextMenusUpdateFunction);
-};
-
-class WebViewInternalContextMenusRemoveFunction
- : public AsyncExtensionFunction {
- public:
- DECLARE_EXTENSION_FUNCTION("webViewInternal.contextMenusRemove",
- WEBVIEWINTERNAL_CONTEXTMENUSREMOVE);
- WebViewInternalContextMenusRemoveFunction() {}
-
- protected:
- virtual ~WebViewInternalContextMenusRemoveFunction() {}
-
- // ExtensionFunction implementation.
- virtual bool RunAsync() OVERRIDE;
-
- private:
- DISALLOW_COPY_AND_ASSIGN(WebViewInternalContextMenusRemoveFunction);
-};
-
-class WebViewInternalContextMenusRemoveAllFunction
- : public AsyncExtensionFunction {
- public:
- DECLARE_EXTENSION_FUNCTION("webViewInternal.contextMenusRemoveAll",
- WEBVIEWINTERNAL_CONTEXTMENUSREMOVEALL);
- WebViewInternalContextMenusRemoveAllFunction() {}
-
- protected:
- virtual ~WebViewInternalContextMenusRemoveAllFunction() {}
-
- // ExtensionFunction implementation.
- virtual bool RunAsync() OVERRIDE;
-
- private:
- DISALLOW_COPY_AND_ASSIGN(WebViewInternalContextMenusRemoveAllFunction);
-};
-
class WebViewInternalNavigateFunction
: public WebViewInternalExtensionFunction {
public:
@@ -367,24 +297,6 @@ class WebViewInternalSetPermissionFunction
DISALLOW_COPY_AND_ASSIGN(WebViewInternalSetPermissionFunction);
};
-class WebViewInternalShowContextMenuFunction
- : public WebViewInternalExtensionFunction {
- public:
- DECLARE_EXTENSION_FUNCTION("webViewInternal.showContextMenu",
- WEBVIEWINTERNAL_SHOWCONTEXTMENU);
-
- WebViewInternalShowContextMenuFunction();
-
- protected:
- virtual ~WebViewInternalShowContextMenuFunction();
-
- private:
- // WebViewInternalExtensionFunction implementation.
- virtual bool RunAsyncSafe(WebViewGuest* guest) OVERRIDE;
-
- DISALLOW_COPY_AND_ASSIGN(WebViewInternalShowContextMenuFunction);
-};
-
class WebViewInternalOverrideUserAgentFunction
: public WebViewInternalExtensionFunction {
public:

Powered by Google App Engine
This is Rietveld 408576698