chrome/browser/extensions/menu_manager.cc - Issue 541753004: Split web_view_internal_api and move part of it to extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/menu_manager.cc

Issue 541753004: Split web_view_internal_api and move part of it to extensions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/web_view/chrome_web_view_internal_api.cc ('K') | « chrome/browser/extensions/api/web_view/web_view_internal_api.cc ('k') | chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.h » ('j') | extensions/browser/api/execute_code_function.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/menu_manager.cc

diff --git a/chrome/browser/extensions/menu_manager.cc b/chrome/browser/extensions/menu_manager.cc

index d20be6248e2a28ab044e687c1d0526eb6fc73d4c..60f9301e20ed2de68e24e8bf33fee5e34d037018 100644

--- a/chrome/browser/extensions/menu_manager.cc

+++ b/chrome/browser/extensions/menu_manager.cc

@@ -18,8 +18,8 @@

#include "chrome/browser/extensions/menu_manager_factory.h"

#include "chrome/browser/extensions/tab_helper.h"

#include "chrome/browser/profiles/profile.h"

+#include "chrome/common/extensions/api/chrome_web_view_internal.h"

#include "chrome/common/extensions/api/context_menus.h"

-#include "chrome/common/extensions/api/web_view_internal.h"

#include "content/public/browser/notification_details.h"

#include "content/public/browser/notification_service.h"

#include "content/public/browser/notification_source.h"

@@ -41,7 +41,7 @@ using extensions::ExtensionSystem;

namespace extensions {

namespace context_menus = api::context_menus;

-namespace web_view = api::web_view_internal;

+namespace chrome_web_view = api::chrome_web_view_internal;

namespace {

@@ -712,7 +712,7 @@ void MenuManager::ExecuteCommand(content::BrowserContext* context,

{

// Dispatch to .contextMenus.onClicked handler.

scoped_ptr<Event> event(

- new Event(webview_guest ? web_view::OnClicked::kEventName

+ new Event(webview_guest ? chrome_web_view::OnClicked::kEventName

: context_menus::OnClicked::kEventName,

args.Pass()));

event->restrict_to_browser_context = context;