Split web_view_internal_api and move part of it to extensions.

Split web_view_internal_api and move part of it to extensions.

BUG=352293
TBR=darin@chromium.org
darin@ TBR'd for dependency on third_party.

Committed: https://crrev.com/e4af45822daf2fb565b4a800e4c33739f17b940d
Cr-Commit-Position: refs/heads/master@{#294394}

[lfg, 2014-09-04 20:36:03]

lfg@chromium.org changed reviewers:
+ fsamuel@chromium.org, hanxi@chromium.org

[lfg, 2014-09-04 20:36:04]

This CL depends on https://codereview.chromium.org/538063003/ which is still in
review.

[Fady Samuel, 2014-09-04 20:41:09]

https://codereview.chromium.org/541753004/diff/1/chrome/browser/extensions/ap...
File chrome/browser/extensions/api/web_view/chrome_web_view_internal_api.cc
(right):

https://codereview.chromium.org/541753004/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/web_view/chrome_web_view_internal_api.cc:22: int
MaskForKey(const char* key) {
This doesn't break WebView Tests?

Don't you need to update web_view.js?

https://codereview.chromium.org/541753004/diff/1/extensions/browser/api/execu...
File extensions/browser/api/execute_code_function.h (right):

https://codereview.chromium.org/541753004/diff/1/extensions/browser/api/execu...
extensions/browser/api/execute_code_function.h:55: void
GetFileURLAndLocalizeCSS(ScriptExecutor::ScriptType script_type,
Can you make this change in the ExecuteCodeFunction CL?

https://codereview.chromium.org/541753004/diff/1/extensions/browser/api/execu...
File extensions/browser/api/execute_code_function_impl.h (right):

https://codereview.chromium.org/541753004/diff/1/extensions/browser/api/execu...
extensions/browser/api/execute_code_function_impl.h:56:
content::BrowserThread::FILE,
Can you make these changes in the ExecuteCodeFunction CL?

[lfg, 2014-09-04 21:05:42]

On 2014/09/04 20:41:09, Fady Samuel wrote:
>
https://codereview.chromium.org/541753004/diff/1/chrome/browser/extensions/ap...
> File chrome/browser/extensions/api/web_view/chrome_web_view_internal_api.cc
> (right):
> 
>
https://codereview.chromium.org/541753004/diff/1/chrome/browser/extensions/ap...
> chrome/browser/extensions/api/web_view/chrome_web_view_internal_api.cc:22: int
> MaskForKey(const char* key) {
> This doesn't break WebView Tests?
> 
> Don't you need to update web_view.js?

Probably does :)

Haven't tried it yet, I'm still working on the other CL, but I just wanted to
upload so you can start to take a look, as it became quite a big change.

>
https://codereview.chromium.org/541753004/diff/1/extensions/browser/api/execu...
> File extensions/browser/api/execute_code_function.h (right):
> 
>
https://codereview.chromium.org/541753004/diff/1/extensions/browser/api/execu...
> extensions/browser/api/execute_code_function.h:55: void
> GetFileURLAndLocalizeCSS(ScriptExecutor::ScriptType script_type,
> Can you make this change in the ExecuteCodeFunction CL?
> 
>
https://codereview.chromium.org/541753004/diff/1/extensions/browser/api/execu...
> File extensions/browser/api/execute_code_function_impl.h (right):
> 
>
https://codereview.chromium.org/541753004/diff/1/extensions/browser/api/execu...
> extensions/browser/api/execute_code_function_impl.h:56:
> content::BrowserThread::FILE,
> Can you make these changes in the ExecuteCodeFunction CL?


Done.

[lfg, 2014-09-08 21:57:14]

fsamuel:

PTAL

[Fady Samuel, 2014-09-08 22:16:32]

lgtm with nits.

https://codereview.chromium.org/541753004/diff/40001/chrome/browser/extension...
File chrome/browser/extensions/api/tabs/tabs_api.cc (right):

https://codereview.chromium.org/541753004/diff/40001/chrome/browser/extension...
chrome/browser/extensions/api/tabs/tabs_api.cc:73: #include
"extensions/common/api/extension_types.h"
Is this necessary?

https://codereview.chromium.org/541753004/diff/40001/chrome/browser/extension...
File chrome/browser/extensions/api/web_view/chrome_web_view_internal_api.cc
(right):

https://codereview.chromium.org/541753004/diff/40001/chrome/browser/extension...
chrome/browser/extensions/api/web_view/chrome_web_view_internal_api.cc:181: bool
ChromeWebViewInternalClearDataFunction::RunAsyncSafe(WebViewGuest* guest) {
Add a TODO to move ClearData to extenisons.

[lfg, 2014-09-08 23:22:57]

On 2014/09/08 22:16:32, Fady Samuel wrote:
> lgtm with nits.
> 
>
https://codereview.chromium.org/541753004/diff/40001/chrome/browser/extension...
> File chrome/browser/extensions/api/tabs/tabs_api.cc (right):
> 
>
https://codereview.chromium.org/541753004/diff/40001/chrome/browser/extension...
> chrome/browser/extensions/api/tabs/tabs_api.cc:73: #include
> "extensions/common/api/extension_types.h"
> Is this necessary?

Yes. Tabs api uses core_api::extension_types::InjectDetails, so if we want to
explicitly include all the dependencies we need it. Before, it was being
included through another dependency.

>
https://codereview.chromium.org/541753004/diff/40001/chrome/browser/extension...
> File chrome/browser/extensions/api/web_view/chrome_web_view_internal_api.cc
> (right):
> 
>
https://codereview.chromium.org/541753004/diff/40001/chrome/browser/extension...
> chrome/browser/extensions/api/web_view/chrome_web_view_internal_api.cc:181:
bool
> ChromeWebViewInternalClearDataFunction::RunAsyncSafe(WebViewGuest* guest) {
> Add a TODO to move ClearData to extenisons.

Done.

[lfg, 2014-09-08 23:24:51]

lfg@chromium.org changed reviewers:
+ rockot@chromium.org

[Ken Rockot(use gerrit already), 2014-09-09 23:20:07]

lgtm

https://codereview.chromium.org/541753004/diff/60001/chrome/common/extensions...
File chrome/common/extensions/api/_api_features.json (right):

https://codereview.chromium.org/541753004/diff/60001/chrome/common/extensions...
chrome/common/extensions/api/_api_features.json:805: "windows": {
I don't think this should have moved?

[lfg, 2014-09-10 14:29:12]

On 2014/09/09 23:20:07, Ken Rockot wrote:
> lgtm
> 
>
https://codereview.chromium.org/541753004/diff/60001/chrome/common/extensions...
> File chrome/common/extensions/api/_api_features.json (right):
> 
>
https://codereview.chromium.org/541753004/diff/60001/chrome/common/extensions...
> chrome/common/extensions/api/_api_features.json:805: "windows": {
> I don't think this should have moved?

No, that was a mistake. Fixed.

[lfg, 2014-09-10 14:32:13]

lfg@chromium.org changed reviewers:
+ sky@chromium.org

[lfg, 2014-09-10 14:32:14]

Could you review changes in:

chrome/renderer/resources/renderer_resources.grd

[lfg, 2014-09-10 14:32:46]

lfg@chromium.org changed reviewers:
+ jamescook@chromium.org

[lfg, 2014-09-10 14:32:47]

jamescook@:

Could you review changes in:

extensions/browser/DEPS

[sky, 2014-09-10 15:11:18]

.grd LGTM

[James Cook, 2014-09-10 18:41:47]

extensions/browser/DEPS lgtm

[lfg, 2014-09-10 20:41:05]

The CQ bit was checked by lfg@chromium.org

[commit-bot: I haz the power, 2014-09-10 21:02:18]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/lfg@chromium.org/541753004/120001

[commit-bot: I haz the power, 2014-09-10 21:23:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-10 21:23:20]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[lfg, 2014-09-10 21:28:28]

The CQ bit was checked by lfg@chromium.org

[commit-bot: I haz the power, 2014-09-10 21:30:18]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/lfg@chromium.org/541753004/120001

[commit-bot: I haz the power, 2014-09-10 23:32:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-10 23:32:49]

Failed to apply patch for extensions/browser/DEPS:
While running git apply --index -p1;
  error: patch failed: extensions/browser/DEPS:12
  error: extensions/browser/DEPS: patch does not apply

Patch:       extensions/browser/DEPS
Index: extensions/browser/DEPS
diff --git a/extensions/browser/DEPS b/extensions/browser/DEPS
index
ca26f8ad0ddfd3e541fd90be1dfaf39c5903509d..3ffc6a3ed0c4d2f2c4f26756e39ac33fe333a243
100644
--- a/extensions/browser/DEPS
+++ b/extensions/browser/DEPS
@@ -12,7 +12,7 @@ include_rules = [
   "+sync",
   "+third_party/leveldatabase",
   "+third_party/skia/include",
-  "+third_party/WebKit/public/web/WebInputEvent.h",
+  "+third_party/WebKit/public/web",
   "+webkit/browser/fileapi",
 ]

[lfg, 2014-09-10 23:35:48]

The CQ bit was checked by lfg@chromium.org

[commit-bot: I haz the power, 2014-09-10 23:49:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/541753004/120001

[commit-bot: I haz the power, 2014-09-10 23:55:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-10 23:55:19]

Failed to apply patch for extensions/browser/DEPS:
While running git apply --index -p1;
  error: patch failed: extensions/browser/DEPS:12
  error: extensions/browser/DEPS: patch does not apply

Patch:       extensions/browser/DEPS
Index: extensions/browser/DEPS
diff --git a/extensions/browser/DEPS b/extensions/browser/DEPS
index
ca26f8ad0ddfd3e541fd90be1dfaf39c5903509d..3ffc6a3ed0c4d2f2c4f26756e39ac33fe333a243
100644
--- a/extensions/browser/DEPS
+++ b/extensions/browser/DEPS
@@ -12,7 +12,7 @@ include_rules = [
   "+sync",
   "+third_party/leveldatabase",
   "+third_party/skia/include",
-  "+third_party/WebKit/public/web/WebInputEvent.h",
+  "+third_party/WebKit/public/web",
   "+webkit/browser/fileapi",
 ]

[lfg, 2014-09-11 14:51:56]

The CQ bit was checked by lfg@chromium.org

[commit-bot: I haz the power, 2014-09-11 14:53:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/541753004/140001

[commit-bot: I haz the power, 2014-09-11 15:53:00]

Committed patchset #8 (id:140001) as 72326f97689004ec16c43a7418f7fb0710a35f73

[commit-bot: I haz the power, 2014-09-11 15:58:54]

Patchset 8 (id:??) landed as
https://crrev.com/e4af45822daf2fb565b4a800e4c33739f17b940d
Cr-Commit-Position: refs/heads/master@{#294394}