Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 541753002: android_webview: stop using system ICU. (Closed)

Created:
6 years, 3 months ago by Torne
Modified:
6 years, 3 months ago
Reviewers:
benm (inactive)
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

android_webview: stop using system ICU. To support unbundled updates we need to stop depending on system libraries. Disable using the system version of ICU and instead link Chromium's copy. This increases binary size by ~7MB. BUG=409851 Committed: https://crrev.com/48e43572c0bfef2b1434d7f330da86cc7770b592 Cr-Commit-Position: refs/heads/master@{#293510}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M android_webview/android_webview.gyp View 1 chunk +10 lines, -0 lines 0 comments Download
M build/common.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
Torne
6 years, 3 months ago (2014-09-04 14:15:31 UTC) #2
Torne
OK, this is now working on the trybot. :)
6 years, 3 months ago (2014-09-05 10:46:04 UTC) #3
benm (inactive)
lgtm
6 years, 3 months ago (2014-09-05 11:43:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/torne@chromium.org/541753002/1
6 years, 3 months ago (2014-09-05 11:54:42 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 159824ea1b9f402caf012597e348e5d6f4440857
6 years, 3 months ago (2014-09-05 13:08:06 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/48e43572c0bfef2b1434d7f330da86cc7770b592 Cr-Commit-Position: refs/heads/master@{#293510}
6 years, 3 months ago (2014-09-10 03:39:11 UTC) #8
Torne
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/570383002/ by torne@chromium.org. ...
6 years, 3 months ago (2014-09-16 15:20:46 UTC) #9
Torne
6 years, 3 months ago (2014-09-16 15:24:19 UTC) #10
Message was sent while issue was closed.
Doh, I'll upload a better manual revert. :)

Powered by Google App Engine
This is Rietveld 408576698