Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 541733002: [turbofan] Save OOL constant pool pointer in CodeGenerator::AssemblePrologue. (Closed)

Created:
6 years, 3 months ago by ulan
Modified:
6 years, 3 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] Save OOL constant pool pointer in CodeGenerator::AssemblePrologue. BUG= R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23843

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M src/compiler/arm/code-generator-arm.cc View 1 chunk +8 lines, -2 lines 1 comment Download

Messages

Total messages: 5 (2 generated)
ulan
PTAL. This fixes test failures that triggered by enabling out of line constant pool. https://codereview.chromium.org/541733002/diff/1/src/compiler/arm/code-generator-arm.cc ...
6 years, 3 months ago (2014-09-04 13:50:10 UTC) #2
Benedikt Meurer
lgtm
6 years, 3 months ago (2014-09-10 12:55:38 UTC) #4
ulan
6 years, 3 months ago (2014-09-10 14:41:06 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 23843 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698