Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Unified Diff: ui/base/ime/win/tsf_text_store_unittest.cc

Issue 54173007: Change the behavior of TSFTextStore::QueryInsert() to support partial commit with Metro MS-IME. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/base/ime/win/tsf_text_store.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/ime/win/tsf_text_store_unittest.cc
diff --git a/ui/base/ime/win/tsf_text_store_unittest.cc b/ui/base/ime/win/tsf_text_store_unittest.cc
index 3a23ef73ac6101769fbc006466e95e84fda10240..cddc83ec4fe1b437e0f6791024c12b8d2f9d4496 100644
--- a/ui/base/ime/win/tsf_text_store_unittest.cc
+++ b/ui/base/ime/win/tsf_text_store_unittest.cc
@@ -323,8 +323,10 @@ TEST_F(TSFTextStoreTest, QueryInsertTest) {
EXPECT_EQ(0, result_end);
*string_buffer() = L"1234";
*committed_size() = 1;
- EXPECT_EQ(E_INVALIDARG,
+ EXPECT_EQ(S_OK,
text_store_->QueryInsert(0, 1, 0, &result_start, &result_end));
+ EXPECT_EQ(1, result_start);
+ EXPECT_EQ(1, result_end);
EXPECT_EQ(E_INVALIDARG,
text_store_->QueryInsert(1, 0, 0, &result_start, &result_end));
EXPECT_EQ(S_OK,
@@ -341,8 +343,10 @@ TEST_F(TSFTextStoreTest, QueryInsertTest) {
text_store_->QueryInsert(3, 4, 0, &result_start, &result_end));
EXPECT_EQ(3, result_start);
EXPECT_EQ(4, result_end);
- EXPECT_EQ(E_INVALIDARG,
+ EXPECT_EQ(S_OK,
text_store_->QueryInsert(3, 5, 0, &result_start, &result_end));
+ EXPECT_EQ(3, result_start);
+ EXPECT_EQ(4, result_end);
}
class SyncRequestLockTestCallback : public TSFTextStoreTestCallback {
« no previous file with comments | « ui/base/ime/win/tsf_text_store.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698