Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 54173007: Change the behavior of TSFTextStore::QueryInsert() to support partial commit with Metro MS-IME. (Closed)

Created:
7 years, 1 month ago by horo
Modified:
7 years, 1 month ago
Reviewers:
yukawa, Seigo Nonaka
CC:
chromium-reviews, nona+watch_chromium.org, James Su, yukishiino+watch_chromium.org, penghuang+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Change the behavior of TSFTextStore::QueryInsert() to support partial commit with Metro MS-IME. BUG=309965 TEST=manually done on Win 8.1 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233500

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -10 lines) Patch
M ui/base/ime/win/tsf_text_store.cc View 1 chunk +7 lines, -8 lines 0 comments Download
M ui/base/ime/win/tsf_text_store_unittest.cc View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 28 (0 generated)
horo
7 years, 1 month ago (2013-11-01 06:48:58 UTC) #1
yukawa
lgtm thanks.
7 years, 1 month ago (2013-11-01 06:50:13 UTC) #2
Seigo Nonaka
lgtm lgtm but please wait Yukawa-san's review.
7 years, 1 month ago (2013-11-01 06:53:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/54173007/1
7 years, 1 month ago (2013-11-01 06:58:13 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=217303
7 years, 1 month ago (2013-11-01 09:30:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/54173007/1
7 years, 1 month ago (2013-11-02 20:14:49 UTC) #6
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=96874
7 years, 1 month ago (2013-11-02 22:53:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/54173007/1
7 years, 1 month ago (2013-11-03 05:16:15 UTC) #8
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=96934
7 years, 1 month ago (2013-11-03 07:17:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/54173007/1
7 years, 1 month ago (2013-11-04 13:37:45 UTC) #10
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=97215
7 years, 1 month ago (2013-11-04 16:18:29 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/54173007/1
7 years, 1 month ago (2013-11-05 00:23:47 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/54173007/1
7 years, 1 month ago (2013-11-05 03:12:58 UTC) #13
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=219444
7 years, 1 month ago (2013-11-05 08:22:49 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/54173007/1
7 years, 1 month ago (2013-11-05 08:25:05 UTC) #15
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=93835
7 years, 1 month ago (2013-11-05 12:00:28 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/54173007/1
7 years, 1 month ago (2013-11-05 15:58:15 UTC) #17
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=94011
7 years, 1 month ago (2013-11-05 20:21:00 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/54173007/1
7 years, 1 month ago (2013-11-05 23:52:36 UTC) #19
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=94356
7 years, 1 month ago (2013-11-06 03:41:48 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/54173007/1
7 years, 1 month ago (2013-11-06 03:56:04 UTC) #21
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=94562
7 years, 1 month ago (2013-11-06 07:07:22 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/54173007/1
7 years, 1 month ago (2013-11-06 07:59:27 UTC) #23
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=94730
7 years, 1 month ago (2013-11-06 11:17:30 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/54173007/1
7 years, 1 month ago (2013-11-06 11:19:10 UTC) #25
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=94820
7 years, 1 month ago (2013-11-06 14:43:21 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/54173007/1
7 years, 1 month ago (2013-11-07 00:36:41 UTC) #27
commit-bot: I haz the power
7 years, 1 month ago (2013-11-07 06:17:26 UTC) #28
Message was sent while issue was closed. 
Change committed as 233500

Powered by Google App Engine
This is Rietveld 408576698