tools/telemetry/telemetry/core/platform/profiler/perf_profiler.py - Issue 541693004: Move remote platform creation logic from cros_browser_finders to platform.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/platform/profiler/perf_profiler.py

Issue 541693004: Move remote platform creation logic from cros_browser_finders to platform. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address achuith's comments Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/core/platform/profiler/perf_profiler.py

diff --git a/tools/telemetry/telemetry/core/platform/profiler/perf_profiler.py b/tools/telemetry/telemetry/core/platform/profiler/perf_profiler.py

index ac2c2ba7434811c880bedc2b248f3dacab30199a..f41625fbb1b5deb9bf7d426b575993138b887d01 100644

--- a/tools/telemetry/telemetry/core/platform/profiler/perf_profiler.py

+++ b/tools/telemetry/telemetry/core/platform/profiler/perf_profiler.py

@@ -14,7 +14,6 @@ from pylib.device import device_errors # pylint: disable=F0401

from telemetry.core import platform

from telemetry.core import util

-from telemetry.core.backends.chrome import cros_interface

from telemetry.core.platform import profiler

from telemetry.core.platform.profiler import android_profiling_helper

from telemetry.util import support_binaries

@@ -200,7 +199,7 @@ class PerfProfiler(profiler.Profiler):

def is_supported(cls, browser_type):

if sys.platform != 'linux2':

return False

- if cros_interface.IsRunningOnCrosDevice():

+ if platform.GetHostPlatform().GetOSName() == 'chromeos':

return False

return True

« no previous file with comments | « tools/telemetry/telemetry/core/platform/device.py ('k') | tools/telemetry/telemetry/util/cloud_storage.py » ('j') | no next file with comments »