Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: tools/telemetry/telemetry/core/platform/cros_interface.py

Issue 541693004: Move remote platform creation logic from cros_browser_finders to platform. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address achuith's comments Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/core/platform/cros_interface.py
diff --git a/tools/telemetry/telemetry/core/backends/chrome/cros_interface.py b/tools/telemetry/telemetry/core/platform/cros_interface.py
similarity index 97%
rename from tools/telemetry/telemetry/core/backends/chrome/cros_interface.py
rename to tools/telemetry/telemetry/core/platform/cros_interface.py
index 6614979b87dd3e1bc57ab15388b235345ad1bc77..a53afe3cfb3d6f29995ecb8abcf2ca3f09a6e3e7 100644
--- a/tools/telemetry/telemetry/core/backends/chrome/cros_interface.py
+++ b/tools/telemetry/telemetry/core/platform/cros_interface.py
@@ -3,11 +3,10 @@
# found in the LICENSE file.
"""A wrapper around ssh for common operations on a CrOS-based device"""
import logging
-import os
import re
+import os
import shutil
import subprocess
-import sys
import tempfile
# Some developers' workflow includes running the Chrome process from
@@ -16,16 +15,6 @@ import tempfile
_CHROME_PATHS = ['/opt/google/chrome/chrome ',
'/usr/local/opt/google/chrome/chrome ']
-def IsRunningOnCrosDevice():
- """Returns True if we're on a ChromeOS device."""
- lsb_release = '/etc/lsb-release'
- if sys.platform.startswith('linux') and os.path.exists(lsb_release):
- with open(lsb_release, 'r') as f:
- res = f.read()
- if res.count('CHROMEOS_RELEASE_NAME'):
- return True
- return False
-
def RunCmd(args, cwd=None, quiet=False):
"""Opens a subprocess to execute a program and returns its return value.

Powered by Google App Engine
This is Rietveld 408576698