tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder.py - Issue 541693004: Move remote platform creation logic from cros_browser_finders to platform.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder.py

Issue 541693004: Move remote platform creation logic from cros_browser_finders to platform. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address achuith's comments Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/backends/chrome/cros_test_case.py ('k') | tools/telemetry/telemetry/core/platform/__init__.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder.py b/tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder.py

index e3e79d9c038b2e034b2a9696d4885603540650fd..b92fc8f6d880953c68a11470aa32690a14fcf7da 100644

--- a/tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder.py

+++ b/tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder.py

@@ -11,7 +11,6 @@ import sys

from telemetry.core import platform as platform_module

from telemetry.core import browser

from telemetry.core import possible_browser

-from telemetry.core.backends.chrome import cros_interface

from telemetry.core.backends.chrome import desktop_browser_backend

from telemetry.util import path

@@ -86,7 +85,7 @@ def SelectDefaultBrowser(possible_browsers):

return None

def CanFindAvailableBrowsers():

- return not cros_interface.IsRunningOnCrosDevice()

+ return not platform_module.GetHostPlatform().GetOSName() == 'chromeos'

def FindAllBrowserTypes(_):

return [