tools/telemetry/telemetry/core/backends/chrome/chrome_browser_options.py - Issue 541693004: Move remote platform creation logic from cros_browser_finders to platform.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/chrome_browser_options.py

Issue 541693004: Move remote platform creation logic from cros_browser_finders to platform. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address achuith's comments Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/core/backends/chrome/chrome_browser_options.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_options.py b/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_options.py

index 89226079e6bf17cd41d1510f7f47f743cd5bc51f..65a9d6b97305bece8ba2b4d17a01cf9825ba468c 100644

--- a/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_options.py

+++ b/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_options.py

@@ -3,13 +3,13 @@

# found in the LICENSE file.

from telemetry.core import browser_options

-from telemetry.core.backends.chrome import cros_interface

+from telemetry.core import platform

def CreateChromeBrowserOptions(br_options):

browser_type = br_options.browser_type

- if (cros_interface.IsRunningOnCrosDevice() or

+ if (platform.GetHostPlatform().GetOSName() == 'chromeos' or

(browser_type and browser_type.startswith('cros'))):

return CrosBrowserOptions(br_options)

« no previous file with comments | « no previous file | tools/telemetry/telemetry/core/backends/chrome/cros_browser_finder.py » ('j') | no next file with comments »