The Password bubble should fade out when user types in the input fields on the web page.

chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h"
 
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_finder.h"
 #include "chrome/browser/ui/passwords/manage_passwords_bubble_model.h"
 #include "chrome/browser/ui/passwords/manage_passwords_ui_controller.h"
 #include "chrome/browser/ui/passwords/save_password_refusal_combobox_model.h"
 #include "chrome/browser/ui/views/frame/browser_view.h"
 #include "chrome/browser/ui/views/location_bar/location_bar_view.h"
 #include "chrome/browser/ui/views/passwords/manage_password_item_view.h"
 #include "chrome/browser/ui/views/passwords/manage_passwords_icon_view.h"
 #include "chrome/grit/generated_resources.h"
+#include "content/public/browser/render_view_host.h"
 #include "content/public/browser/web_contents.h"
 #include "ui/aura/window.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/compositor/layer_animation_observer.h"
 #include "ui/compositor/scoped_layer_animation_settings.h"
 #include "ui/views/controls/button/blue_button.h"
 #include "ui/views/controls/button/label_button.h"
 #include "ui/views/controls/combobox/combobox.h"
 #include "ui/views/controls/combobox/combobox_listener.h"
@@ skipping 602 matching lines @@
 void ManagePasswordsBubbleView::SaveConfirmationView::ButtonPressed(
     views::Button* sender, const ui::Event& event) {
   DCHECK_EQ(sender, ok_button_);
   parent_->model()->OnOKClicked();
   parent_->Close();
 }
 
 // ManagePasswordsBubbleView::WebContentMouseHandler --------------------------
 
 // The class listens for WebContentsView events and notifies the bubble if the
-// view was clicked on.
+// view was clicked on or received keystrokes.
 class ManagePasswordsBubbleView::WebContentMouseHandler
     : public ui::EventHandler {
  public:
-  explicit WebContentMouseHandler(ManagePasswordsBubbleView* bubble)
-      : bubble_(bubble) {
-    GetWebContentsWindow()->AddPreTargetHandler(this);
-  }
+  explicit WebContentMouseHandler(ManagePasswordsBubbleView* bubble);
+  virtual ~WebContentMouseHandler();
 
-  virtual ~WebContentMouseHandler() {
-    aura::Window* window = GetWebContentsWindow();
-    if (window)
-      window->RemovePreTargetHandler(this);
-  }
-
-  virtual void OnMouseEvent(ui::MouseEvent* event) OVERRIDE {
-    if (event->type() == ui::ET_MOUSE_PRESSED)
-      bubble_->StartFadingOut();
-  }
+  virtual void OnKeyEvent(ui::KeyEvent* event) OVERRIDE;
+  virtual void OnMouseEvent(ui::MouseEvent* event) OVERRIDE;
 
  private:
-  aura::Window* GetWebContentsWindow() {
-    content::WebContents* web_contents = bubble_->model()->web_contents();
-    return web_contents ? web_contents->GetNativeView() : NULL;
-  }
+  aura::Window* GetWebContentsWindow();
 
   ManagePasswordsBubbleView* bubble_;
 
   DISALLOW_COPY_AND_ASSIGN(WebContentMouseHandler);
 };
 
+ManagePasswordsBubbleView::WebContentMouseHandler::WebContentMouseHandler(
+    ManagePasswordsBubbleView* bubble) : bubble_(bubble) {

[Mike West, 2014/09/08 14:53:16]

Nit: Shouldn't the initialization be on a separate line? What does `git cl
format` say?

[vasilii, 2014/09/08 16:25:44]

Done.

+  GetWebContentsWindow()->AddPreTargetHandler(this);
+}
+
+ManagePasswordsBubbleView::WebContentMouseHandler::~WebContentMouseHandler() {
+  aura::Window* window = GetWebContentsWindow();
+  if (window)

[Mike West, 2014/09/08 14:53:16]

Nit: You can do this in one line. `if (aura::Window* ...)`

[vasilii, 2014/09/08 16:25:44]

Done. Some reviewers don't like assignment in if().

+    window->RemovePreTargetHandler(this);
+}
+
+void ManagePasswordsBubbleView::WebContentMouseHandler::OnKeyEvent(
+    ui::KeyEvent* event) {
+  content::WebContents* web_contents = bubble_->model()->web_contents();

[Mike West, 2014/09/08 14:53:16]

Nit: I'd skip |web_contents|; it'll never be NULL, so just grab the
RenderViewHost directly.

[vasilii, 2014/09/08 16:25:44]

content::RenderViewHost* rvh =
bubble_->model()->web_contents()->GetRenderViewHost();

two lines anyway.

+  content::RenderViewHost* rvh = web_contents->GetRenderViewHost();
+  if (rvh->IsFocusedElementEditable() &&
+      event->type() == ui::ET_KEY_PRESSED)
+    bubble_->StartFadingOut();
+}
+
+void ManagePasswordsBubbleView::WebContentMouseHandler::OnMouseEvent(
+    ui::MouseEvent* event) {
+  if (event->type() == ui::ET_MOUSE_PRESSED)
+    bubble_->StartFadingOut();
+}
+
+aura::Window*
+ManagePasswordsBubbleView::WebContentMouseHandler::GetWebContentsWindow() {
+  content::WebContents* web_contents = bubble_->model()->web_contents();
+  return web_contents ? web_contents->GetNativeView() : NULL;

[Mike West, 2014/09/08 14:53:16]

Nit: Will |web_contents| ever be null? Doesn't the bubble view only exist in the
context of a WebContents?

[vasilii, 2014/09/08 16:25:44]

It's NULL if you close the tab with the bubble. The bubble and WebContents are
destroyed simultaneously.

+}
+
 // ManagePasswordsBubbleView::FadeOutObserver ---------------------------------
 
 // The class notifies the bubble when it faded out completely.
 class ManagePasswordsBubbleView::FadeOutObserver
     : public ui::ImplicitAnimationObserver {
  public:
   explicit FadeOutObserver(ManagePasswordsBubbleView* bubble)
       : bubble_(bubble) {
   }
 
@@ skipping 199 matching lines @@
   if (!fadeout_observer_)
     return;
   fadeout_observer_.reset();
   aura::Window* window = GetWidget()->GetNativeView();
   window->layer()->SetOpacity(1);
 }
 
 void ManagePasswordsBubbleView::OnBubbleDisappeared() {
   Close();
 }