content/browser/devtools/renderer_overrides_handler_browsertest.cc - Issue 541663002: Simplify IOSurface CoreAnimation code: Part 2

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/browser/devtools/renderer_overrides_handler_browsertest.cc

Issue 541663002: Simplify IOSurface CoreAnimation code: Part 2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/base64.h"	5 #include "base/base64.h"

6 #include "base/command_line.h"	6 #include "base/command_line.h"

7 #include "base/json/json_reader.h"	7 #include "base/json/json_reader.h"

8 #include "content/browser/devtools/devtools_protocol.h"	8 #include "content/browser/devtools/devtools_protocol.h"

9 #include "content/public/browser/devtools_agent_host.h"	9 #include "content/public/browser/devtools_agent_host.h"

10 #include "content/public/browser/web_contents.h"	10 #include "content/public/browser/web_contents.h"

(...skipping 107 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
118 "document.body.style.background = '#123456'"));	118 "document.body.style.background = '#123456'"));

119 SendCommand("Page.captureScreenshot", new base::DictionaryValue());	119 SendCommand("Page.captureScreenshot", new base::DictionaryValue());

120 std::string base64;	120 std::string base64;

121 EXPECT_TRUE(result_->GetString("data", &base64));	121 EXPECT_TRUE(result_->GetString("data", &base64));

122 std::string png;	122 std::string png;

123 EXPECT_TRUE(base::Base64Decode(base64, &png));	123 EXPECT_TRUE(base::Base64Decode(base64, &png));

124 SkBitmap bitmap;	124 SkBitmap bitmap;

125 gfx::PNGCodec::Decode(reinterpret_cast<const unsigned char*>(png.data()),	125 gfx::PNGCodec::Decode(reinterpret_cast<const unsigned char*>(png.data()),

126 png.size(), &bitmap);	126 png.size(), &bitmap);

127 SkColor color(bitmap.getColor(0, 0));	127 SkColor color(bitmap.getColor(0, 0));

128 EXPECT_TRUE(std::abs(0x12-(int)SkColorGetR(color)) <= 1);	128 EXPECT_LE(std::abs(0x12-(int)SkColorGetR(color)), 1);
	Ken Russell (switch to Gerrit) 2014/09/04 22:20:36 Needs to be resynced? These changes look unrelated Needs to be resynced? These changes look unrelated. ccameron 2014/09/04 23:01:01 Oh -- this was a test that was failing with this t Show quoted text On 2014/09/04 22:20:36, Ken Russell wrote: > Needs to be resynced? These changes look unrelated. Oh -- this was a test that was failing with this test (a while ago), and it was much more useful to use EXPECT_LE (to see what the actual pixel values were).
129 EXPECT_TRUE(std::abs(0x34-(int)SkColorGetG(color)) <= 1);	129 EXPECT_LE(std::abs(0x34-(int)SkColorGetG(color)), 1);

130 EXPECT_TRUE(std::abs(0x56-(int)SkColorGetB(color)) <= 1);	130 EXPECT_LE(std::abs(0x56-(int)SkColorGetB(color)), 1);

131 }	131 }

132	132

133 } // namespace content	133 } // namespace content

OLD	NEW

« content/browser/compositor/io_surface_layer_mac.mm ('K') | « content/browser/compositor/io_surface_layer_mac.mm ('k') | no next file » | no next file with comments »