Issue 541643002: [turbofan] Properly delete nodes in the GraphReducer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 541643002: [turbofan] Properly delete nodes in the GraphReducer. (Closed)

Created:
6 years, 3 months ago by Benedikt Meurer

Modified:
6 years, 3 months ago

Reviewers:
Jarin

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

[turbofan] Properly delete nodes in the GraphReducer. This is required to enable a value numbering reducer, which needs to be able to recognize "dead nodes". TEST=compiler-unittests,cctest R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23675

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+131 lines, -7 lines)			Patch
M	src/compiler/compiler.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/compiler/graph-reducer.cc	View	1 2	3 chunks	+8 lines, -5 lines	0 comments	Download
A	src/compiler/graph-reducer-unittest.cc	View		1 chunk	+111 lines, -0 lines	0 comments	Download
M	src/compiler/node.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/compiler/node.cc	View	1 2	1 chunk	+8 lines, -0 lines	0 comments	Download
M	test/cctest/compiler/test-graph-reducer.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 5 (1 generated)

Benedikt Meurer

6 years, 3 months ago (2014-09-04 09:22:22 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as 23675 (presubmit successful).