Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Side by Side Diff: base/guid_posix.cc

Issue 541633005: Make GUID generation on POSIX compliant with GUID v4 format. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | base/guid_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/guid.h" 5 #include "base/guid.h"
6 6
7 #include "base/rand_util.h" 7 #include "base/rand_util.h"
8 #include "base/strings/stringprintf.h" 8 #include "base/strings/stringprintf.h"
9 9
10 namespace base { 10 namespace base {
11 11
12 std::string GenerateGUID() { 12 std::string GenerateGUID() {
13 uint64 sixteen_bytes[2] = { base::RandUint64(), base::RandUint64() }; 13 uint64 sixteen_bytes[2] = { base::RandUint64(), base::RandUint64() };
14
15 // Set the GUID to version 4 as described in RFC 4122, section 4.4.
16 // The format of GUID version 4 must be xxxxxxxx-xxxx-4xxx-yxxx-xxxxxxxxxxxx,
17 // where y is one of [8, 9, A, B].
18
19 // Clear the version bits and set the version to 4:
20 sixteen_bytes[0] &= 0xffffffffffff0fffULL;
21 sixteen_bytes[0] |= 0x0000000000004000ULL;
22
23 // Set the two most significant bits (bits 6 and 7) of the
24 // clock_seq_hi_and_reserved to zero and one, respectively:
25 sixteen_bytes[1] &= 0x3fffffffffffffffULL;
26 sixteen_bytes[1] |= 0x8000000000000000ULL;
27
14 return RandomDataToGUIDString(sixteen_bytes); 28 return RandomDataToGUIDString(sixteen_bytes);
15 } 29 }
16 30
17 // TODO(cmasone): Once we're comfortable this works, migrate Windows code to 31 // TODO(cmasone): Once we're comfortable this works, migrate Windows code to
18 // use this as well. 32 // use this as well.
19 std::string RandomDataToGUIDString(const uint64 bytes[2]) { 33 std::string RandomDataToGUIDString(const uint64 bytes[2]) {
20 return StringPrintf("%08X-%04X-%04X-%04X-%012llX", 34 return StringPrintf("%08X-%04X-%04X-%04X-%012llX",
21 static_cast<unsigned int>(bytes[0] >> 32), 35 static_cast<unsigned int>(bytes[0] >> 32),
22 static_cast<unsigned int>((bytes[0] >> 16) & 0x0000ffff), 36 static_cast<unsigned int>((bytes[0] >> 16) & 0x0000ffff),
23 static_cast<unsigned int>(bytes[0] & 0x0000ffff), 37 static_cast<unsigned int>(bytes[0] & 0x0000ffff),
24 static_cast<unsigned int>(bytes[1] >> 48), 38 static_cast<unsigned int>(bytes[1] >> 48),
25 bytes[1] & 0x0000ffffffffffffULL); 39 bytes[1] & 0x0000ffffffffffffULL);
26 } 40 }
27 41
28 } // namespace guid 42 } // namespace guid
OLDNEW
« no previous file with comments | « no previous file | base/guid_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698