Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 541633005: Make GUID generation on POSIX compliant with GUID v4 format. (Closed)

Created:
6 years, 3 months ago by Ben Chan
Modified:
6 years, 3 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, Alex Vakulenko
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make GUID generation on POSIX compliant with GUID v4 format. Per RFC 4122 section 4.4, the format of GUID version 4 must be xxxxxxxx-xxxx-4xxx-yxxx-xxxxxxxxxxxx, where y is one of [8, 9, A, B]. This CL updates base::GenerateGUID() on POSIX to be compliant with the GUID v4 format. This fix is proposed by Alex Vakulenko <avakulenko@chromium.org>; BUG=None TEST=base_unittests Committed: https://crrev.com/87119864277bb405bf1303d98691f5acd5add403 Cr-Commit-Position: refs/heads/master@{#293518}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -0 lines) Patch
M base/guid_posix.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M base/guid_unittest.cc View 2 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Ben Chan
6 years, 3 months ago (2014-09-05 07:07:33 UTC) #2
Mark Mentovai
LGTM
6 years, 3 months ago (2014-09-05 12:43:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benchan@chromium.org/541633005/1
6 years, 3 months ago (2014-09-05 13:02:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 2bd522accb1d13fd8de22012b493b669f236c4c1
6 years, 3 months ago (2014-09-05 14:29:21 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:39:30 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/87119864277bb405bf1303d98691f5acd5add403
Cr-Commit-Position: refs/heads/master@{#293518}

Powered by Google App Engine
This is Rietveld 408576698