Source/core/dom/Range.h - Issue 541633004: Avoid temporary range allocation in FrameSelection::respondToNodeModification.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Range.h

Issue 541633004: Avoid temporary range allocation in FrameSelection::respondToNodeModification. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/Range.h

diff --git a/Source/core/dom/Range.h b/Source/core/dom/Range.h

index 92f78de4f05818846fbb512aae3121fba937edc8..16526e2959d1173bd82430d2f9726bf90b682d81 100644

--- a/Source/core/dom/Range.h

+++ b/Source/core/dom/Range.h

@@ -78,6 +78,7 @@ public:

static short compareBoundaryPoints(const RangeBoundaryPoint& boundaryA, const RangeBoundaryPoint& boundaryB, ExceptionState&);

bool boundaryPointsValid() const;

bool intersectsNode(Node* refNode, ExceptionState&);

+ static bool intersectsNode(Node* refNode, Position& start, Position& end, ExceptionState&);

yosin_UTC9 2014/09/05 01:07:56 nit: Let's use |const Position&|.

Mads Ager (chromium) 2014/09/05 08:22:52 Done.

void deleteContents(ExceptionState&);

PassRefPtrWillBeRawPtr<DocumentFragment> extractContents(ExceptionState&);

PassRefPtrWillBeRawPtr<DocumentFragment> cloneContents(ExceptionState&);

« no previous file with comments | « no previous file | Source/core/dom/Range.cpp » ('j') | Source/core/editing/VisibleSelection.cpp » ('J')