Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 541633003: Fix and enable java validation tests. (Closed)

Created:
6 years, 3 months ago by qsr
Modified:
6 years, 3 months ago
Reviewers:
ppi
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix and enable java validation tests. Passing invalid handle was incorrect, because some handle were supposed to be not null. Change the test to use mock handles instead. NOTRY=true R=ppi@chromium.org Committed: https://crrev.com/61ac9f51a58bdfc97f8e2624b1496cc208247ed4 Cr-Commit-Position: refs/heads/master@{#293287}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M mojo/android/javatests/src/org/chromium/mojo/bindings/ValidationTest.java View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
qsr
6 years, 3 months ago (2014-09-04 10:47:05 UTC) #1
ppi
lgtm, maybe edit the title to say "fix and enable"
6 years, 3 months ago (2014-09-04 11:38:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/541633003/1
6 years, 3 months ago (2014-09-04 11:42:26 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as 5685ab14f382e2c5940e27b9d14fc10c0fdfec7d
6 years, 3 months ago (2014-09-04 11:44:56 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:31:01 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/61ac9f51a58bdfc97f8e2624b1496cc208247ed4
Cr-Commit-Position: refs/heads/master@{#293287}

Powered by Google App Engine
This is Rietveld 408576698