Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 541623002: Files.app: Remove scanning notification. (Closed)

Created:
6 years, 3 months ago by hirono
Modified:
6 years, 3 months ago
Reviewers:
mtomasz
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Files.app: Remove scanning notification. The CL removes "device scanning" notification and the relative logic in device_event_router.cc. BUG=408011 TEST=manually TBR=benwells@chromium.org TBR for removing two event types from IDL. Committed: https://crrev.com/de4fd92b0ce257687affc81738865419b2ecc0cd Cr-Commit-Position: refs/heads/master@{#294334}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -135 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/device_event_router.h View 1 2 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/device_event_router.cc View 1 2 3 4 chunks +2 lines, -37 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/device_event_router_unittest.cc View 1 2 1 chunk +0 lines, -44 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/file_manager_private.idl View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/test/data/file_manager/unit_tests/device_handler_unittest.js View 1 2 2 chunks +0 lines, -24 lines 0 comments Download
M ui/file_manager/file_manager/background/js/device_handler.js View 1 2 3 chunks +0 lines, -17 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
hirono
PTAL the CL? Thank you!
6 years, 3 months ago (2014-09-10 12:53:38 UTC) #2
mtomasz
lgtm!
6 years, 3 months ago (2014-09-11 03:06:42 UTC) #3
hirono
On 2014/09/11 03:06:42, mtomasz wrote: > lgtm! Thanks!
6 years, 3 months ago (2014-09-11 03:14:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/541623002/60001
6 years, 3 months ago (2014-09-11 03:18:15 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/10205)
6 years, 3 months ago (2014-09-11 03:28:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/541623002/60001
6 years, 3 months ago (2014-09-11 04:43:49 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001) as 500fd4d89fd2b3d3781a67ea159709fbad183681
6 years, 3 months ago (2014-09-11 06:02:15 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 06:04:40 UTC) #12
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/de4fd92b0ce257687affc81738865419b2ecc0cd
Cr-Commit-Position: refs/heads/master@{#294334}

Powered by Google App Engine
This is Rietveld 408576698