Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 541603003: DevTools: [Documentation] Fix css style for renderer (Closed)

Created:
6 years, 3 months ago by iliia
Modified:
6 years, 3 months ago
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

DevTools: [Documentation] Fix css style for renderer Based on issue 519653002 BUG=391593 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181457

Patch Set 1 #

Patch Set 2 : fix percentages #

Total comments: 4

Patch Set 3 : rebase #

Patch Set 4 : delete file #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -22 lines) Patch
M Source/devtools/front_end/documentation/DocumentationView.js View 1 chunk +1 line, -1 line 1 comment Download
M Source/devtools/front_end/documentationView.css View 1 2 3 chunks +21 lines, -21 lines 3 comments Download

Messages

Total messages: 16 (5 generated)
iliia
comments addressed
6 years, 3 months ago (2014-09-04 09:39:04 UTC) #2
lushnikov
https://codereview.chromium.org/541603003/diff/20001/Source/devtools/front_end/documentationView.css File Source/devtools/front_end/documentationView.css (left): https://codereview.chromium.org/541603003/diff/20001/Source/devtools/front_end/documentationView.css#oldcode31 Source/devtools/front_end/documentationView.css:31: .documentation-highlighted-text { why remove this class? https://codereview.chromium.org/541603003/diff/20001/Source/devtools/front_end/documentationView.css#oldcode43 Source/devtools/front_end/documentationView.css:43: .documentation-parameter ...
6 years, 3 months ago (2014-09-04 12:19:45 UTC) #3
iliia
https://codereview.chromium.org/541603003/diff/20001/Source/devtools/front_end/documentationView.css File Source/devtools/front_end/documentationView.css (left): https://codereview.chromium.org/541603003/diff/20001/Source/devtools/front_end/documentationView.css#oldcode31 Source/devtools/front_end/documentationView.css:31: .documentation-highlighted-text { On 2014/09/04 12:19:45, lushnikov wrote: > why ...
6 years, 3 months ago (2014-09-04 15:28:37 UTC) #4
lushnikov
https://codereview.chromium.org/541603003/diff/60001/Source/devtools/front_end/documentation/DocumentationView.js File Source/devtools/front_end/documentation/DocumentationView.js (right): https://codereview.chromium.org/541603003/diff/60001/Source/devtools/front_end/documentation/DocumentationView.js#newcode255 Source/devtools/front_end/documentation/DocumentationView.js:255: element = document.createElement(article.hasBullet() ? "li" : "p"); rendering only ...
6 years, 3 months ago (2014-09-04 16:27:16 UTC) #5
lushnikov
lgtm as per offline discussion
6 years, 3 months ago (2014-09-05 07:53:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iliia@google.com/541603003/60001
6 years, 3 months ago (2014-09-05 07:54:35 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/14489)
6 years, 3 months ago (2014-09-05 08:03:49 UTC) #10
loislo
rubber stamp lgtm
6 years, 3 months ago (2014-09-05 08:16:57 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iliia@google.com/541603003/60001
6 years, 3 months ago (2014-09-05 08:17:40 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001) as 181457
6 years, 3 months ago (2014-09-05 09:55:47 UTC) #14
aandrey
6 years, 3 months ago (2014-09-05 11:11:49 UTC) #16
Message was sent while issue was closed. 
FYI

https://codereview.chromium.org/541603003/diff/60001/Source/devtools/front_en...
File Source/devtools/front_end/documentationView.css (right):

https://codereview.chromium.org/541603003/diff/60001/Source/devtools/front_en...
Source/devtools/front_end/documentationView.css:14: .documentation-code {
duplicated css. merge with the above:

.documentation-code,
.documentation-example-code {
  ...
}

https://codereview.chromium.org/541603003/diff/60001/Source/devtools/front_en...
Source/devtools/front_end/documentationView.css:62: margin-top: 5px;
use "margin: x x x x;"

https://codereview.chromium.org/541603003/diff/60001/Source/devtools/front_en...
Source/devtools/front_end/documentationView.css:86: .documentation-example-link
{
too much css duplication for:

.documentation-parameter-optional
.documentation-parameter-data-type-value
.documentation-example-link

Powered by Google App Engine
This is Rietveld 408576698