Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1043)

Unified Diff: Source/core/html/HTMLMediaElement.cpp

Issue 541593004: Make markCaptionAndSubtitleTracksAsUnconfigured() do what the box say (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLMediaElement.cpp
diff --git a/Source/core/html/HTMLMediaElement.cpp b/Source/core/html/HTMLMediaElement.cpp
index 91ef6708e6f5e78594ef9b36ad751aec9955cc39..89ab90f031ffb3ca76ae75f3a8ca7f72896df8cd 100644
--- a/Source/core/html/HTMLMediaElement.cpp
+++ b/Source/core/html/HTMLMediaElement.cpp
@@ -3567,8 +3567,9 @@ void HTMLMediaElement::setClosedCaptionsVisible(bool closedCaptionVisible)
m_closedCaptionsVisible = closedCaptionVisible;
- m_processingPreferenceChange = true;
markCaptionAndSubtitleTracksAsUnconfigured();
+ m_processingPreferenceChange = true;
+ configureTextTracks();
m_processingPreferenceChange = false;
updateTextTrackDisplay();
@@ -3712,7 +3713,6 @@ void HTMLMediaElement::markCaptionAndSubtitleTracksAsUnconfigured()
if (kind == TextTrack::subtitlesKeyword() || kind == TextTrack::captionsKeyword())
textTrack->setHasBeenConfigured(false);
}
- configureTextTracks();
}
void* HTMLMediaElement::preDispatchEventHandler(Event* event)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698