Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 541533002: Remove more label for= use. (Closed)

Created:
6 years, 3 months ago by Evan Stade
Modified:
6 years, 3 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove more label for= use. BUG=409938 Committed: https://crrev.com/f459aa1d6a3eae9b9a0bf3fca5e2eea1be0f5c65 Cr-Commit-Position: refs/heads/master@{#293403}

Patch Set 1 #

Total comments: 2

Patch Set 2 : sync #

Total comments: 3

Patch Set 3 : fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -92 lines) Patch
M chrome/browser/resources/options/browser_options.css View 2 chunks +8 lines, -1 line 0 comments Download
M chrome/browser/resources/options/browser_options.html View 1 2 1 chunk +30 lines, -38 lines 0 comments Download
M chrome/browser/resources/options/browser_options.js View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/resources/options/startup_section.html View 1 chunk +25 lines, -36 lines 0 comments Download
M chrome/browser/resources/options/sync_section.html View 1 chunk +9 lines, -11 lines 0 comments Download
M chrome/browser/ui/webui/options/settings_format_browsertest.js View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
Evan Stade
https://codereview.chromium.org/541533002/diff/1/chrome/browser/resources/options/browser_options.html File chrome/browser/resources/options/browser_options.html (right): https://codereview.chromium.org/541533002/diff/1/chrome/browser/resources/options/browser_options.html#newcode765 chrome/browser/resources/options/browser_options.html:765: <input id="accessibility-autoclick-check" this id is used https://codereview.chromium.org/541533002/diff/1/chrome/browser/resources/options/browser_options.html#newcode777 chrome/browser/resources/options/browser_options.html:777: </span><select ...
6 years, 3 months ago (2014-09-03 23:44:47 UTC) #2
arv (Not doing code reviews)
https://codereview.chromium.org/541533002/diff/20001/chrome/browser/resources/options/browser_options.js File chrome/browser/resources/options/browser_options.js (left): https://codereview.chromium.org/541533002/diff/20001/chrome/browser/resources/options/browser_options.js#oldcode320 chrome/browser/resources/options/browser_options.js:320: document.querySelector( Why was this removed?
6 years, 3 months ago (2014-09-04 16:48:40 UTC) #3
Evan Stade
https://codereview.chromium.org/541533002/diff/20001/chrome/browser/resources/options/browser_options.js File chrome/browser/resources/options/browser_options.js (left): https://codereview.chromium.org/541533002/diff/20001/chrome/browser/resources/options/browser_options.js#oldcode320 chrome/browser/resources/options/browser_options.js:320: document.querySelector( On 2014/09/04 16:48:40, arv wrote: > Why was ...
6 years, 3 months ago (2014-09-04 17:25:39 UTC) #4
arv (Not doing code reviews)
LGTM
6 years, 3 months ago (2014-09-04 17:42:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/541533002/20001
6 years, 3 months ago (2014-09-04 18:00:27 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/11033)
6 years, 3 months ago (2014-09-04 22:50:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/541533002/40001
6 years, 3 months ago (2014-09-05 00:14:17 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 03bd5bd9573e881a167dff9240d8115cc55cd818
6 years, 3 months ago (2014-09-05 02:17:34 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:35:40 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f459aa1d6a3eae9b9a0bf3fca5e2eea1be0f5c65
Cr-Commit-Position: refs/heads/master@{#293403}

Powered by Google App Engine
This is Rietveld 408576698