Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1539)

Issue 541513002: MIPS: Clean up code stubs and ensure distinct major keys. (Closed)

Created:
6 years, 3 months ago by akos.palfi.imgtec
Modified:
6 years, 3 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

MIPS: Clean up code stubs and ensure distinct major keys. Port r23655 (6327324d) BUG= R=machenbach@chromium.org, paul.lind@imgtec.com Committed: https://code.google.com/p/v8/source/detail?r=23674

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -103 lines) Patch
M src/code-stubs.h View 1 chunk +4 lines, -4 lines 0 comments Download
M src/ic/mips/handler-compiler-mips.cc View 1 chunk +0 lines, -29 lines 0 comments Download
M src/ic/mips64/handler-compiler-mips64.cc View 1 chunk +0 lines, -30 lines 0 comments Download
M src/mips/code-stubs-mips.h View 6 chunks +6 lines, -6 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 11 chunks +13 lines, -14 lines 0 comments Download
M src/mips64/code-stubs-mips64.h View 6 chunks +6 lines, -6 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 11 chunks +13 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
akos.palfi.imgtec
PTAL.
6 years, 3 months ago (2014-09-03 22:47:05 UTC) #2
paul.l...
+reviewers: machenbach, jarin (sheriff) LGTM, but this touches src/code-stubs.h and needs v8 team review.
6 years, 3 months ago (2014-09-03 23:37:24 UTC) #4
Michael Achenbach
lgtm
6 years, 3 months ago (2014-09-04 08:39:16 UTC) #5
akos.palfi.imgtec
6 years, 3 months ago (2014-09-04 08:59:55 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 23674 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698