Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 541363002: Support StreamCopyOrMoveImpl in sandbox. (Closed)

Created:
6 years, 3 months ago by iseki
Modified:
6 years, 3 months ago
Reviewers:
tzik
CC:
chromium-reviews, darin-cc_chromium.org, jam, kinuko+fileapi, nhiroki, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Support StreamCopyOrMoveImpl in sandbox. StreamCopyOrMoveImpl has some issue. * Return infelicity error code. * Don't notify to observer. This issue is fixed in Issue 522543002 so we can support it in sandbox. BUG=360088 TEST=content_unittests passed Committed: https://crrev.com/9d31d5191dfca9be7bec3e128fad130def533b60 Cr-Commit-Position: refs/heads/master@{#293677}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M content/browser/fileapi/file_system_operation_impl_unittest.cc View 1 3 chunks +7 lines, -5 lines 0 comments Download
M storage/browser/fileapi/sandbox_file_system_backend.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
iseki
Sorry, I missed the modification about sandbox in Issue 522543002. Please take a look.
6 years, 3 months ago (2014-09-05 07:50:53 UTC) #2
tzik
lgtm
6 years, 3 months ago (2014-09-08 02:26:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iseki@chromium.org/541363002/1
6 years, 3 months ago (2014-09-08 02:32:40 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_swarming/builds/13809) ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/12672)
6 years, 3 months ago (2014-09-08 02:36:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iseki@chromium.org/541363002/20001
6 years, 3 months ago (2014-09-08 03:53:11 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 46aee6b75f9ca23e0bf5238df13c979885f92a97
6 years, 3 months ago (2014-09-08 06:51:37 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:44:45 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9d31d5191dfca9be7bec3e128fad130def533b60
Cr-Commit-Position: refs/heads/master@{#293677}

Powered by Google App Engine
This is Rietveld 408576698