Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 541293004: Revert of Cast: Re-factor rtcp_sender.cc into rtcp_builder.cc and do some cleanup (Closed)

Created:
6 years, 3 months ago by Noel Gordon
Modified:
6 years, 3 months ago
Reviewers:
hubbe, miu
CC:
chromium-reviews, hclam+watch_chromium.org, cbentzel+watch_chromium.org, imcheng+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, pwestin+watch_google.com, feature-media-reviews_chromium.org, miu+watch_chromium.org, hubbe+watch_chromium.org, mikhal+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Cast: Re-factor rtcp_sender.cc into rtcp_builder.cc and do some cleanup (patchset #3 id:40001 of https://codereview.chromium.org/513313004/) Reason for revert: Caused cast_unittest rtcp test failures on Linux Asan Lsan builders (memory leaks). http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/7132 Original issue's description: > Cast: Re-factor rtcp_sender.cc into rtcp_builder.cc and do some cleanup > > Committed: https://chromium.googlesource.com/chromium/src/+/6217e450d9e75037c62fff773c94aebe7f3ed2e6 TBR=miu@chromium.org,hubbe@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/6cdfc247ea7233ffd1eda000eb4ada794508eedd Cr-Commit-Position: refs/heads/master@{#293665}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1302 lines, -1146 lines) Patch
M media/cast/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
M media/cast/cast.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
M media/cast/cast_testing.gypi View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/net/rtcp/rtcp.h View 3 chunks +2 lines, -4 lines 0 comments Download
M media/cast/net/rtcp/rtcp.cc View 4 chunks +9 lines, -15 lines 0 comments Download
D media/cast/net/rtcp/rtcp_builder.h View 1 chunk +0 lines, -90 lines 0 comments Download
D media/cast/net/rtcp/rtcp_builder.cc View 1 chunk +0 lines, -549 lines 0 comments Download
D media/cast/net/rtcp/rtcp_builder_unittest.cc View 1 chunk +0 lines, -482 lines 0 comments Download
A media/cast/net/rtcp/rtcp_sender.h View 1 chunk +107 lines, -0 lines 0 comments Download
A media/cast/net/rtcp/rtcp_sender.cc View 1 chunk +636 lines, -0 lines 0 comments Download
A media/cast/net/rtcp/rtcp_sender_unittest.cc View 1 chunk +542 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Noel Gordon
Created Revert of Cast: Re-factor rtcp_sender.cc into rtcp_builder.cc and do some cleanup
6 years, 3 months ago (2014-09-07 20:39:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noel@chromium.org/541293004/1
6 years, 3 months ago (2014-09-07 20:39:29 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as c25e54eb09c4bb26377548695a2ca90d5ffd9eeb
6 years, 3 months ago (2014-09-07 20:41:21 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:44:19 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6cdfc247ea7233ffd1eda000eb4ada794508eedd
Cr-Commit-Position: refs/heads/master@{#293665}

Powered by Google App Engine
This is Rietveld 408576698