Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 541253002: [Telemetry] Add 'important' to JSON output. (Closed)

Created:
6 years, 3 months ago by eakuefner
Modified:
6 years, 3 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Add 'important' to JSON output. We have a plan in progress to upgrade the 'important' field to a combination of two fields 'primary' and 'improvement_direction'. This will be a two-sided patch that will require reworking the dashboard's handling of chart JSON. Since the dashboard has been modified to accept chart JSON with 'important' values, we want to update Telemetry to continue serializing values with this field for now. R=nednguyen Committed: https://crrev.com/ba3e74deda690c0c30877a3396b4c0c9c6bbb497 Cr-Commit-Position: refs/heads/master@{#293468}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tools/telemetry/telemetry/value/__init__.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/value/value_unittest.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
eakuefner
6 years, 3 months ago (2014-09-05 00:19:43 UTC) #1
nednguyen
lgtm
6 years, 3 months ago (2014-09-05 03:03:11 UTC) #2
nednguyen
lgtm lgtm
6 years, 3 months ago (2014-09-05 03:03:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eakuefner@chromium.org/541253002/1
6 years, 3 months ago (2014-09-05 03:03:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 80de52c1fd28c8d77e9e660247c88522204130bb
6 years, 3 months ago (2014-09-05 08:11:36 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:37:45 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ba3e74deda690c0c30877a3396b4c0c9c6bbb497
Cr-Commit-Position: refs/heads/master@{#293468}

Powered by Google App Engine
This is Rietveld 408576698