Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 541243003: More fixes for scoped_refptr operator T* removal. (Closed)

Created:
6 years, 3 months ago by dcheng
Modified:
6 years, 3 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, cbentzel+watch_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

More fixes for scoped_refptr operator T* removal. Fix a couple more dependencies on implicit conversions that have been checked in since this morning. BUG=110610 R=vtl@google.com TBR=rsleevi, vtl, yzshen Committed: https://chromium.googlesource.com/chromium/src/+/99adf749397997bbb0a36cde6f48aba9c25bc4d5

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M content/renderer/pepper/ppb_var_deprecated_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/channel.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/proxy_config_service_linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (2 generated)
dcheng
One step forward, two steps back! TBRing these changes since they are pretty trivial.
6 years, 3 months ago (2014-09-05 05:29:15 UTC) #2
vtl
not lgtm
6 years, 3 months ago (2014-09-05 05:40:00 UTC) #3
vtl
https://codereview.chromium.org/541243003/diff/1/mojo/system/channel_endpoint.h File mojo/system/channel_endpoint.h (right): https://codereview.chromium.org/541243003/diff/1/mojo/system/channel_endpoint.h#newcode106 mojo/system/channel_endpoint.h:106: ChannelEndpoint(const scoped_refptr<MessagePipe>& message_pipe, Why? The original form is fine, ...
6 years, 3 months ago (2014-09-05 05:41:52 UTC) #4
dcheng
+gab, +rvargas who I think have expressed some opinions on this in the past. Also ...
6 years, 3 months ago (2014-09-05 06:01:27 UTC) #6
vtl
On 2014/09/05 06:01:27, dcheng (OOO) wrote: > +gab, +rvargas who I think have expressed some ...
6 years, 3 months ago (2014-09-05 06:22:43 UTC) #7
vtl
lgtm
6 years, 3 months ago (2014-09-05 06:22:49 UTC) #8
dcheng
Committed patchset #2 (id:20001) manually as 99adf74 (tree was closed).
6 years, 3 months ago (2014-09-05 06:30:40 UTC) #9
dcheng
On 2014/09/05 at 06:22:43, vtl wrote: > On 2014/09/05 06:01:27, dcheng (OOO) wrote: > > ...
6 years, 3 months ago (2014-09-05 06:41:41 UTC) #10
chromium-reviews
On Thu, Sep 4, 2014 at 11:41 PM, <dcheng@chromium.org> wrote: > On 2014/09/05 at 06:22:43, ...
6 years, 3 months ago (2014-09-05 16:53:11 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:37:27 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/99adf749397997bbb0a36cde6f48aba9c25bc4d5
Cr-Commit-Position: refs/heads/master@{#293458}

Powered by Google App Engine
This is Rietveld 408576698