Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 541233003: Add Linux and Win site isolation builder_testers to chromium.fyi waterfall. (Closed)

Created:
6 years, 3 months ago by awong
Modified:
6 years, 2 months ago
Reviewers:
Dirk Pranke, iannucci
CC:
chromium-reviews, pgervais+watch_chromium.org, kjellander-cc_chromium.org, cmp-cc_chromium.org, stip+watch_chromium.org, site-isolation-dev_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@propagate_args
Project:
tools
Visibility:
Public.

Description

Add Linux and Win site isolation builder_testers to chromium.fyi waterfall. BUG=405765 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=291836

Patch Set 1 #

Patch Set 2 : Fixed unittests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -23 lines) Patch
M masters/master.chromium.fyi/master.cfg View 2 chunks +18 lines, -0 lines 0 comments Download
M masters/master.chromium.fyi/slaves.cfg View 1 chunk +16 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/chromium_fyi.py View 1 chunk +37 lines, -0 lines 0 comments Download
A + scripts/slave/recipes/chromium.expected/full_chromium_fyi_Site_Isolation_Linux.json View 1 4 chunks +6 lines, -6 lines 0 comments Download
A + scripts/slave/recipes/chromium.expected/full_chromium_fyi_Site_Isolation_Win.json View 1 7 chunks +18 lines, -17 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
awong
Double Yay.
6 years, 3 months ago (2014-09-05 02:05:41 UTC) #2
Dirk Pranke
lgtm
6 years, 3 months ago (2014-09-05 20:15:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajwong@chromium.org/541233003/20001
6 years, 3 months ago (2014-09-05 21:45:46 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-05 21:46:21 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 291836

Powered by Google App Engine
This is Rietveld 408576698