android: Add screen recording tool

android: Add screen recording tool

Add a tool to record screen capture videos from Android devices. This
patch introduces both a standalone tool as well as a telemetry profiler
which captures a video of a telemetry run.

Note that the screen recording functionality requires Android KitKat or
later.

TEST=tools/perf/run_benchmark run --profiler=android-screen-recorder --browser=android-chrome smoothness.top_25 --page-filter=news.yahoo

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233686

[Sami, 2013-10-31 18:50:50]

PTAL.

+tonyg@ in case he can think of some use for this in the perf dashboards or
elsewhere.

[bulach, 2013-11-04 16:59:43]

sorry about the delay, this looks really cool! I wonder how accurate is the
video wrt to vsync and whats the overhead.. perhaps we could use this for speed
index instead of webcams? anyways, just some small comments:

https://codereview.chromium.org/54123005/diff/1/build/android/adb_record_scre...
File build/android/adb_record_screen.py (right):

https://codereview.chromium.org/54123005/diff/1/build/android/adb_record_scre...
build/android/adb_record_screen.py:32: recorder = cmd_helper.Popen(['adb',
'shell', 'screenrecord', video_file])
-s serial?

https://codereview.chromium.org/54123005/diff/1/build/android/adb_record_scre...
build/android/adb_record_screen.py:37: recorder.send_signal(signal.SIGINT)
iirc, this does not do what I thought it would ;)
that is, it'll kill "adb shell" with sigint, and probably terminate
"screenrecord" with a sigkill (or sighup, not quite sure)...

probably need to send a sigint to the "inferior" first:
https://code.google.com/p/chromium/codesearch#chromium/src/tools/telemetry/te...

https://codereview.chromium.org/54123005/diff/1/build/android/adb_record_scre...
build/android/adb_record_screen.py:49: parser =
optparse.OptionParser(description='Record screen capture videos on '
there's a "screenshot.py" already.. perhaps add a "--video" there?

https://code.google.com/p/chromium/codesearch#chromium/src/build/android/scre...

maybe best to move "_CaptureAndPullVideo" to its own component in something like
pylib/screenshot.py, exposing Start / Stop / Pull methods? so then this becomes
a very shallow shell on top of it.. wdyt?

[Sami, 2013-11-07 16:08:02]

Thanks for the comments!

> I wonder how accurate is the video wrt to vsync and whats the overhead.. 

Since the recorder is integrated into SurfaceFlinger it should be very accurate.
From what I can tell it records each and every rendered frame -- and only every
rendered frame. For instance if you scroll, pause for a bit and then continue
scrolling, the paused part consists of only one frame. Looks like this confuses
some video players since the frame times aren't monotonic.

With the pages I tried I didn't see a large overhead from the recording -- at
least at 4 mbps. I was really only looking at the framerate, though, and this
could definitely affect CPU/memory/disk bandwidth. We could probably tweak the
bitrate to limit the impact.

> perhaps we could use this for speed index instead of 
> webcams?

Interesting idea. I was also thinking of checking for checkerboarding, but I
guess we already can compute that pretty well in the compositor.

https://codereview.chromium.org/54123005/diff/1/build/android/adb_record_scre...
File build/android/adb_record_screen.py (right):

https://codereview.chromium.org/54123005/diff/1/build/android/adb_record_scre...
build/android/adb_record_screen.py:32: recorder = cmd_helper.Popen(['adb',
'shell', 'screenrecord', video_file])
On 2013/11/04 16:59:44, bulach wrote:
> -s serial?

Done. (I went with -d/--device to match telemetry.)

https://codereview.chromium.org/54123005/diff/1/build/android/adb_record_scre...
build/android/adb_record_screen.py:37: recorder.send_signal(signal.SIGINT)
On 2013/11/04 16:59:44, bulach wrote:
> iirc, this does not do what I thought it would ;)
> that is, it'll kill "adb shell" with sigint, and probably terminate
> "screenrecord" with a sigkill (or sighup, not quite sure)...
> 
> probably need to send a sigint to the "inferior" first:
>
https://code.google.com/p/chromium/codesearch#chromium/src/tools/telemetry/te...
> 

Thanks for pointing this out. Now I know why my videos were sometimes getting
truncated :)

https://codereview.chromium.org/54123005/diff/1/build/android/adb_record_scre...
build/android/adb_record_screen.py:49: parser =
optparse.OptionParser(description='Record screen capture videos on '
On 2013/11/04 16:59:44, bulach wrote:
> there's a "screenshot.py" already.. perhaps add a "--video" there?
> 
>
https://code.google.com/p/chromium/codesearch#chromium/src/build/android/scre...
> 
> maybe best to move "_CaptureAndPullVideo" to its own component in something
like
> pylib/screenshot.py, exposing Start / Stop / Pull methods? so then this
becomes
> a very shallow shell on top of it.. wdyt?

Great idea, I didn't know about screenshot.py. I've now merged the two.

[bulach, 2013-11-07 17:38:57]

lgtm, thanks! just one suggestion below:

https://codereview.chromium.org/54123005/diff/80001/build/android/screenshot.py
File build/android/screenshot.py (left):

https://codereview.chromium.org/54123005/diff/80001/build/android/screenshot....
build/android/screenshot.py:29: parser.add_option('-f', '--file',
dest='filename',
I think this is called by the buildbots... :(
any chance of keeping this API?

[Sami, 2013-11-07 17:47:28]

On 2013/11/07 17:38:57, bulach wrote:
> lgtm, thanks! just one suggestion below:
> 
>
https://codereview.chromium.org/54123005/diff/80001/build/android/screenshot.py
> File build/android/screenshot.py (left):
> 
>
https://codereview.chromium.org/54123005/diff/80001/build/android/screenshot....
> build/android/screenshot.py:29: parser.add_option('-f', '--file',
> dest='filename',
> I think this is called by the buildbots... :(
> any chance of keeping this API?

Oh, I didn't know that. Fixed. I'll take out the NOTRY too.

[commit-bot: I haz the power, 2013-11-07 17:49:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skyostil@chromium.org/54123005/110001

[commit-bot: I haz the power, 2013-11-07 21:17:26]

Change committed as 233686