Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 541213002: Run mig to generate the exc and mach_exc interfaces (Closed)

Created:
6 years, 3 months ago by Mark Mentovai
Modified:
6 years, 3 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

Run mig to generate the exc and mach_exc interfaces. mach_exc is necessary because libSystem doesn’t contain this at all. exc is necessary too, however: the copy in libSystem relies on the server callbacks being externally defined symbols, which is cheesey. Additionally, some Crashpad code wants to call internal validation (“check”) routines that are not normally accessible to outside callers via the copy of exc in libSystem, but they are made accessible here by processing mig’s output in this Python script. R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/5a0b7827ff367c07828e2e23e4be9f05bfe2af68

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -0 lines) Patch
A util/mach/mig.py View 1 1 chunk +123 lines, -0 lines 0 comments Download
M util/util.gyp View 1 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Mark Mentovai
How about a little Python for a change?
6 years, 3 months ago (2014-09-04 22:56:30 UTC) #2
Robert Sesek
https://codereview.chromium.org/541213002/diff/1/util/mach/mig.py File util/mach/mig.py (right): https://codereview.chromium.org/541213002/diff/1/util/mach/mig.py#newcode22 util/mach/mig.py:22: # This function rewrites the file at |implementation| by ...
6 years, 3 months ago (2014-09-05 16:32:38 UTC) #3
Mark Mentovai
Updated.
6 years, 3 months ago (2014-09-05 16:48:54 UTC) #4
Robert Sesek
LGTM
6 years, 3 months ago (2014-09-05 17:16:40 UTC) #5
Mark Mentovai
6 years, 3 months ago (2014-09-05 17:27:10 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 5a0b782 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698