content/browser/media/capture/desktop_capture_device_unittest.cc - Issue 541163002: Clarify resolution change behaviors of video capture devices

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/media/capture/desktop_capture_device_unittest.cc

Issue 541163002: Clarify resolution change behaviors of video capture devices (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: merged Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/media/capture/desktop_capture_device_unittest.cc

diff --git a/content/browser/media/capture/desktop_capture_device_unittest.cc b/content/browser/media/capture/desktop_capture_device_unittest.cc

index 5d37d117a18068f9488a2e78ed326267ee036cde..e1ce84b894f9ba9f31efb30047928a49b82a969b 100644

--- a/content/browser/media/capture/desktop_capture_device_unittest.cc

+++ b/content/browser/media/capture/desktop_capture_device_unittest.cc

@@ -172,7 +172,6 @@ TEST_F(DesktopCaptureDeviceTest, MAYBE_Capture) {

capture_params.requested_format.frame_size.SetSize(640, 480);

capture_params.requested_format.frame_rate = kFrameRate;

capture_params.requested_format.pixel_format = media::PIXEL_FORMAT_I420;

- capture_params.allow_resolution_change = false;

capture_device_->AllocateAndStart(

capture_params, client.PassAs<media::VideoCaptureDevice::Client>());

EXPECT_TRUE(done_event.TimedWait(TestTimeouts::action_max_timeout()));

@@ -209,7 +208,6 @@ TEST_F(DesktopCaptureDeviceTest, ScreenResolutionChangeConstantResolution) {

kTestFrameHeight1);

capture_params.requested_format.frame_rate = kFrameRate;

capture_params.requested_format.pixel_format = media::PIXEL_FORMAT_I420;

- capture_params.allow_resolution_change = false;

capture_device_->AllocateAndStart(

capture_params, client.PassAs<media::VideoCaptureDevice::Client>());

@@ -251,7 +249,6 @@ TEST_F(DesktopCaptureDeviceTest, ScreenResolutionChangeVariableResolution) {

kTestFrameHeight2);

capture_params.requested_format.frame_rate = kFrameRate;

capture_params.requested_format.pixel_format = media::PIXEL_FORMAT_I420;

- capture_params.allow_resolution_change = false;

capture_device_->AllocateAndStart(

capture_params, client.PassAs<media::VideoCaptureDevice::Client>());