Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 541153002: Hook up resources to the chrome GN build. (Closed)

Created:
6 years, 3 months ago by brettw
Modified:
6 years, 3 months ago
Reviewers:
jamesr
CC:
chromium-reviews, vsevik, jam, yurys, paulirish+reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Committed: https://crrev.com/6a90cafc8e2b0f1e1bc6a8f7e69470ac8acfa253 Cr-Commit-Position: refs/heads/master@{#293360}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+539 lines, -2 lines) Patch
M build/config/BUILD.gn View 1 chunk +6 lines, -0 lines 0 comments Download
A build/config/locales.gni View 1 chunk +118 lines, -0 lines 0 comments Download
M build/config/ui.gni View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/BUILD.gn View 1 4 chunks +229 lines, -1 line 0 comments Download
M chrome/chrome_repack_chrome_100_percent.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_repack_chrome_200_percent.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/chrome_repack_locales.gni View 1 1 chunk +174 lines, -0 lines 0 comments Download
M chrome/chrome_resources.gyp View 4 chunks +4 lines, -0 lines 0 comments Download
M content/browser/devtools/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M device/bluetooth/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
brettw
chrome_repack_locales.gni is horrible but it's still shorter than all the gyp code plus the 219 ...
6 years, 3 months ago (2014-09-04 21:58:53 UTC) #2
jamesr
lgtm
6 years, 3 months ago (2014-09-04 22:06:41 UTC) #3
brettw
Committed patchset #2 (id:20001) to pending queue manually as 4b345e3.
6 years, 3 months ago (2014-09-04 22:29:21 UTC) #4
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:33:24 UTC) #5
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6a90cafc8e2b0f1e1bc6a8f7e69470ac8acfa253
Cr-Commit-Position: refs/heads/master@{#293360}

Powered by Google App Engine
This is Rietveld 408576698