Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issue 541133002: Add XDG_CURRENT_DESKTOP and GDMSESSION env to about:gpu on Linux. (Closed)

Created:
6 years, 3 months ago by Zhenyao Mo
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add XDG_CURRENT_DESKTOP and GDMSESSION env to about:gpu on Linux. BUG=410560 TEST=about:gpu page on Linux R=piman@chromium.org,kbr@chromium.org Committed: https://crrev.com/ead6b552e80aa1f05539abff07a78e90fdac0f15 Cr-Commit-Position: refs/heads/master@{#293425}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M content/browser/gpu/gpu_internals_ui.cc View 1 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
Zhenyao Mo
Please review
6 years, 3 months ago (2014-09-04 21:36:14 UTC) #1
Ken Russell (switch to Gerrit)
LGTM with one modification. https://codereview.chromium.org/541133002/diff/1/content/browser/gpu/gpu_internals_ui.cc File content/browser/gpu/gpu_internals_ui.cc (right): https://codereview.chromium.org/541133002/diff/1/content/browser/gpu/gpu_internals_ui.cc#newcode174 content/browser/gpu/gpu_internals_ui.cc:174: { This block should go ...
6 years, 3 months ago (2014-09-04 21:48:35 UTC) #2
Zhenyao Mo
https://codereview.chromium.org/541133002/diff/1/content/browser/gpu/gpu_internals_ui.cc File content/browser/gpu/gpu_internals_ui.cc (right): https://codereview.chromium.org/541133002/diff/1/content/browser/gpu/gpu_internals_ui.cc#newcode174 content/browser/gpu/gpu_internals_ui.cc:174: { On 2014/09/04 21:48:34, Ken Russell wrote: > This ...
6 years, 3 months ago (2014-09-04 21:51:54 UTC) #3
piman
LGTM. The other thing that might be useful is to know whether or not there ...
6 years, 3 months ago (2014-09-04 23:54:50 UTC) #4
Zhenyao Mo
On 2014/09/04 23:54:50, piman (OOO) wrote: > LGTM. > > The other thing that might ...
6 years, 3 months ago (2014-09-05 00:12:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zmo@chromium.org/541133002/20001
6 years, 3 months ago (2014-09-05 00:14:21 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 3d53ae90183462abce4749487ee07c2c96237049
6 years, 3 months ago (2014-09-05 03:47:16 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:36:23 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ead6b552e80aa1f05539abff07a78e90fdac0f15
Cr-Commit-Position: refs/heads/master@{#293425}

Powered by Google App Engine
This is Rietveld 408576698