Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1256)

Unified Diff: Tools/GardeningServer/ui/ct-failure-card.html

Issue 541123002: Move builderList creation to ct-failure-card (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: re-add builderList to Polymer() Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/GardeningServer/ui/ct-failure-card.html
diff --git a/Tools/GardeningServer/ui/ct-failure-card.html b/Tools/GardeningServer/ui/ct-failure-card.html
index 84dca8b99bc095496a5a6785ab3384426da56358..fe457d78066faccdd70f3eeee91e46b5eb748b8b 100644
--- a/Tools/GardeningServer/ui/ct-failure-card.html
+++ b/Tools/GardeningServer/ui/ct-failure-card.html
@@ -65,7 +65,7 @@ found in the LICENSE file.
opacity: 0.5;
}
</style>
- <ct-builder-grid failures="{{ group.failures }}"></ct-builder-grid>
+ <ct-builder-grid builderList="{{ _builderList }}"></ct-builder-grid>
<div id="failure" class="{{ { snoozed: group.isSnoozed } | tokenList }}">
<ct-test-list tests="{{ group.failures }}" tree="{{ tree }}"></ct-test-list>
<ct-commit-list commitList="{{ group.commitList }}"></ct-commit-list>
@@ -97,11 +97,13 @@ found in the LICENSE file.
Polymer({
group: null,
commitLog: null,
+ builderList: null,
tree: '',
observe: {
group: '_updateCommitList',
- commitLog: '_updateCommitList'
+ commitLog: '_updateCommitList',
+ 'group.failures': '_updateBuilderList',
ojan 2014/09/05 01:18:04 Woah. Didn't realize you could do this.
cbiesinger 2014/09/06 00:25:56 Yeah, also $.foo.bar for polymer elements in your
},
examine: function() {
@@ -121,6 +123,10 @@ found in the LICENSE file.
this.group.commitList.update(this.commitLog);
},
+ _updateBuilderList: function() {
+ this._builderList = new CTBuilderList(this.group.failures);
ojan 2014/09/05 01:18:04 I think we still have a bug where we won't update
cbiesinger 2014/09/06 00:25:56 Oy, that's true, but I have no idea how to fix tha
+ },
+
linkBug: function() {
this.$.bug.value = this.group.bug;
this.$.bugDialog.toggle();
« no previous file with comments | « Tools/GardeningServer/ui/ct-builder-grid.html ('k') | Tools/GardeningServer/ui/test/ct-builder-grid-tests.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698