Introduce ChromeZoomLevelPref, make zoom level prefs independent of profile prefs.

chrome/browser/prefs/browser_prefs.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/prefs/browser_prefs.h"
 
 #include <string>
 
 #include "base/debug/trace_event.h"
+#include "base/metrics/histogram.h"
 #include "base/prefs/pref_registry_simple.h"
 #include "base/prefs/pref_service.h"
+#include "base/prefs/scoped_user_pref_update.h"
 #include "chrome/browser/about_flags.h"
 #include "chrome/browser/accessibility/invert_bubble_prefs.h"
 #include "chrome/browser/apps/drive/drive_app_mapping.h"
 #include "chrome/browser/apps/shortcut_manager.h"
 #include "chrome/browser/autocomplete/zero_suggest_provider.h"
 #include "chrome/browser/background/background_mode_manager.h"
 #include "chrome/browser/browser_process_impl.h"
 #include "chrome/browser/browser_shutdown.h"
 #include "chrome/browser/chrome_content_browser_client.h"
 #include "chrome/browser/component_updater/recovery_component_installer.h"
@@ skipping 49 matching lines @@
 #include "chrome/browser/ui/prefs/prefs_tab_helper.h"
 #include "chrome/browser/ui/search_engines/keyword_editor_controller.h"
 #include "chrome/browser/ui/startup/autolaunch_prompt.h"
 #include "chrome/browser/ui/startup/default_browser_prompt.h"
 #include "chrome/browser/ui/tabs/pinned_tab_codec.h"
 #include "chrome/browser/ui/webui/flags_ui.h"
 #include "chrome/browser/ui/webui/instant_ui.h"
 #include "chrome/browser/ui/webui/ntp/new_tab_ui.h"
 #include "chrome/browser/ui/webui/plugins_ui.h"
 #include "chrome/browser/ui/webui/print_preview/sticky_settings.h"
+#include "chrome/browser/ui/zoom/chrome_zoom_level_prefs.h"
 #include "chrome/browser/upgrade_detector.h"
 #include "chrome/browser/web_resource/promo_resource_service.h"
 #include "chrome/common/pref_names.h"
 #include "components/autofill/core/browser/autofill_manager.h"
 #include "components/bookmarks/browser/bookmark_utils.h"
 #include "components/dom_distiller/core/distilled_page_prefs.h"
 #include "components/enhanced_bookmarks/bookmark_server_cluster_service.h"
 #include "components/gcm_driver/gcm_channel_status_syncer.h"
 #include "components/google/core/browser/google_pref_names.h"
 #include "components/google/core/browser/google_url_tracker.h"
@@ skipping 542 matching lines @@
 
 #if defined(OS_CHROMEOS)
   chromeos::default_pinned_apps_field_trial::MigratePrefs(local_state);
 #endif
 
 #if defined(TOOLKIT_VIEWS)
   MigrateBrowserTabStripPrefs(local_state);
 #endif
 }
 
+// As part of the migration from per-profile to per-partition HostZoomMaps,
+// we need to detect if an existing per-profile set of preferences exist, and
+// if so convert them to be per-partition. We migrate any per-profile zoom
+// level prefs via zoom_level_prefs.
+// Code that updates zoom prefs in the profile prefs store has been removed,
+// so once we clear these values here, they should never get set again.
+// TODO(wjmaclean): Remove this migration machinery after histograms show
+// that an aceptable percentage of users have been migrated.
+// crbug.com/420643
+void MigrateProfileZoomLevelPrefs(Profile* profile) {

[sky, 2014/10/10 19:43:59]

Is there test coverage of this?

[wjmaclean, 2014/10/10 20:23:02]

Yes, a browser_test:

HostZoomMapMigrationBrowserTest.MigrateProfileZoomPreferences

+  PrefService* prefs = profile->GetPrefs();
+  chrome::ChromeZoomLevelPrefs* zoom_level_prefs = profile->GetZoomLevelPrefs();
+  DCHECK(zoom_level_prefs);
+
+  bool migrated = false;
+  // Only migrate the default zoom level if it is not equal to the registered
+  // default for the preference.
+  const base::Value* per_profile_default_zoom_level_value =
+      prefs->GetUserPrefValue(prefs::kDefaultZoomLevelDeprecated);
+  if (per_profile_default_zoom_level_value) {
+    if (per_profile_default_zoom_level_value->GetType() ==
+           base::Value::TYPE_DOUBLE) {
+      double per_profile_default_zoom_level = 0.0;
+      per_profile_default_zoom_level_value->GetAsDouble(

[sky, 2014/10/10 19:43:59]

Add a temp here and DCHECK returns true.

[wjmaclean, 2014/10/10 20:23:02]

Done.

+          &per_profile_default_zoom_level);
+      zoom_level_prefs->SetDefaultZoomLevelPref(per_profile_default_zoom_level);
+    }
+    prefs->ClearPref(prefs::kDefaultZoomLevelDeprecated);
+    migrated = true;
+  }
+
+  const base::DictionaryValue* host_zoom_dictionary =
+      prefs->GetDictionary(prefs::kPerHostZoomLevelsDeprecated);
+  // Collect stats on frequency with which migrations are occuring. This measure
+  // is not perfect, since it will consider an un-migrated user with only
+  // default value as being already migrated, but it will catch all non-trivial
+  // migrations.
+  migrated |= !host_zoom_dictionary->empty();
+  UMA_HISTOGRAM_BOOLEAN("Settings.ZoomLevelPreferencesMigrated", migrated);
+
+  zoom_level_prefs->ExtractPerHostZoomLevels(host_zoom_dictionary);
+
+  // We're done migrating the profile per-host zoom level values, so we clear
+  // them all.
+  DictionaryPrefUpdate host_zoom_dictionary_update(
+      prefs, prefs::kPerHostZoomLevelsDeprecated);
+  host_zoom_dictionary_update->Clear();
+}
+
 }  // namespace chrome