Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 541013002: Fix the buttons in the mojo demo window manager debug panel. (Closed)

Created:
6 years, 3 months ago by Ben Goodger (Google)
Modified:
6 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), aa
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix the buttons in the mojo demo window manager debug panel. NWVM was using the ScopedCaptureClient to attach a capture controller. The problem with this is that the window manager already made one, and there is only one capture controller when you use SCC and this was screwing with event dispatch as coordinate systems between the different root windows were different (not sure this is a condition we've ever really designed for in aura). Anyway. Made NWVM use DefaultCaptureClient directly. R=sky@chromium.org BUG= Committed: https://crrev.com/47738b92b25f25ea0e384a02427a49c22d545b24 Cr-Commit-Position: refs/heads/master@{#293522}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M mojo/views/native_widget_view_manager.h View 3 chunks +7 lines, -2 lines 0 comments Download
M mojo/views/native_widget_view_manager.cc View 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Ben Goodger (Google)
6 years, 3 months ago (2014-09-04 18:13:19 UTC) #1
sky
LGTM
6 years, 3 months ago (2014-09-04 18:28:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/541013002/1
6 years, 3 months ago (2014-09-05 14:19:05 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as 4e52da8e4dc82f29ea8b0ee2e2777747ef2c91c0
6 years, 3 months ago (2014-09-05 14:57:02 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:39:38 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/47738b92b25f25ea0e384a02427a49c22d545b24
Cr-Commit-Position: refs/heads/master@{#293522}

Powered by Google App Engine
This is Rietveld 408576698