Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 540993002: [android_webview] Android.mk file cleanup. (Closed)

Created:
6 years, 3 months ago by mkosiba (inactive)
Modified:
6 years, 2 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[android_webview] Android.mk file cleanup. We don't use the android_webview_java target anymore, get rid of it and the resource_map entries. Also, get rid of the res_hack folder since we now have a real resources folder in our source tree. BUG=None TEST=compile on android_aosp bot TBR=miguelg@chromium.org Committed: https://crrev.com/866abeb12e42c99b18479d4ed9fa712df39c667b Cr-Commit-Position: refs/heads/master@{#296695}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -254 lines) Patch
M android_webview/Android.mk View 1 2 1 chunk +1 line, -23 lines 0 comments Download
D android_webview/build/res_hack/values/values.xml View 1 chunk +0 lines, -11 lines 0 comments Download
M android_webview/build/resources_config.mk View 1 1 chunk +0 lines, -7 lines 0 comments Download
D content/public/android/java/resource_map/OWNERS View 1 2 1 chunk +0 lines, -14 lines 0 comments Download
D content/public/android/java/resource_map/org/chromium/content/R.java View 1 2 1 chunk +0 lines, -107 lines 0 comments Download
D ui/android/java/resource_map/OWNERS View 1 2 1 chunk +0 lines, -14 lines 0 comments Download
D ui/android/java/resource_map/org/chromium/ui/R.java View 1 2 1 chunk +0 lines, -78 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
mkosiba (inactive)
6 years, 2 months ago (2014-09-25 11:12:52 UTC) #2
benm (inactive)
lgtm
6 years, 2 months ago (2014-09-25 11:15:08 UTC) #3
mkosiba (inactive)
+Miguel for ui/android stamp
6 years, 2 months ago (2014-09-25 11:31:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/540993002/40001
6 years, 2 months ago (2014-09-25 11:38:00 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001) as f3dfc410f5c027d7ede8f93b91e39377622b004a
6 years, 2 months ago (2014-09-25 12:13:30 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-09-25 12:14:04 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/866abeb12e42c99b18479d4ed9fa712df39c667b
Cr-Commit-Position: refs/heads/master@{#296695}

Powered by Google App Engine
This is Rietveld 408576698