Issue 540973002: Add cwd to all shell commands in auto roll scripts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 540973002: Add cwd to all shell commands in auto roll scripts. (Closed)

Created:
6 years, 3 months ago by Michael Achenbach

Modified:
6 years, 3 months ago

Reviewers:
Jarin

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Add cwd to all shell commands in auto roll scripts. The v8 root directory is assumed to be the default cwd. All commands executed in another directory (e.g. the chromium checkout) need an explicit specification (also in the tests). This also fixes several small testing and robustness bugs: - Get rid of all 'rm ...' shell calls - Don't leak tmp files/dirs - Add some forgotten shell calls to the test expectations - Hardcode the DEPS location (must always be chromium_dir/DEPS) - Expect correct return code when terminating gracefully BUG=chromium:408523 LOG=n TBR=jarin@chromium.org TEST=script_test.py Committed: https://code.google.com/p/v8/source/detail?r=23719

Patch Set 1 : #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+266 lines, -233 lines)			Patch
M	tools/push-to-trunk/chromium_roll.py	View	4 chunks	+25 lines, -24 lines	0 comments	Download
M	tools/push-to-trunk/common_includes.py	View	9 chunks	+40 lines, -14 lines	0 comments	Download
M	tools/push-to-trunk/git_recipes.py	View	8 chunks	+69 lines, -65 lines	0 comments	Download
M	tools/push-to-trunk/push_to_trunk.py	View	3 chunks	+3 lines, -2 lines	0 comments	Download
M	tools/push-to-trunk/releases.py	View	11 chunks	+27 lines, -62 lines	0 comments	Download
M	tools/push-to-trunk/test_scripts.py	View	23 chunks	+102 lines, -66 lines	0 comments	Download

Messages

Total messages: 5 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Michael Achenbach

6 years, 3 months ago (2014-09-05 09:19:58 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:20002) manually as 23719 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages