Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: tests/TileGridTest.cpp

Issue 540963002: Change SkPicture::draw to playback (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright 2012 Google Inc. 2 * Copyright 2012 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #include "SkCanvas.h" 8 #include "SkCanvas.h"
9 #include "SkPictureRecorder.h" 9 #include "SkPictureRecorder.h"
10 #include "SkTileGrid.h" 10 #include "SkTileGrid.h"
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
66 canvas->drawRect(rect1, paint); 66 canvas->drawRect(rect1, paint);
67 canvas->drawRect(rect2, paint); 67 canvas->drawRect(rect2, paint);
68 SkAutoTUnref<SkPicture> picture(recorder.endRecording()); 68 SkAutoTUnref<SkPicture> picture(recorder.endRecording());
69 69
70 SkBitmap store; 70 SkBitmap store;
71 store.allocN32Pixels(1, 1); 71 store.allocN32Pixels(1, 1);
72 72
73 // Test parts of top-left tile 73 // Test parts of top-left tile
74 { 74 {
75 MockCanvas mockCanvas(store); 75 MockCanvas mockCanvas(store);
76 picture->draw(&mockCanvas); 76 picture->playback(&mockCanvas);
77 REPORTER_ASSERT(reporter, 1 == mockCanvas.fRects.count()); 77 REPORTER_ASSERT(reporter, 1 == mockCanvas.fRects.count());
78 REPORTER_ASSERT(reporter, rect1 == mockCanvas.fRects[0]); 78 REPORTER_ASSERT(reporter, rect1 == mockCanvas.fRects[0]);
79 } 79 }
80 { 80 {
81 MockCanvas mockCanvas(store); 81 MockCanvas mockCanvas(store);
82 mockCanvas.translate(-7.99f, -7.99f); 82 mockCanvas.translate(-7.99f, -7.99f);
83 picture->draw(&mockCanvas); 83 picture->playback(&mockCanvas);
84 REPORTER_ASSERT(reporter, 1 == mockCanvas.fRects.count()); 84 REPORTER_ASSERT(reporter, 1 == mockCanvas.fRects.count());
85 REPORTER_ASSERT(reporter, rect1 == mockCanvas.fRects[0]); 85 REPORTER_ASSERT(reporter, rect1 == mockCanvas.fRects[0]);
86 } 86 }
87 // Corner overlap 87 // Corner overlap
88 { 88 {
89 MockCanvas mockCanvas(store); 89 MockCanvas mockCanvas(store);
90 mockCanvas.translate(-9.5f, -9.5f); 90 mockCanvas.translate(-9.5f, -9.5f);
91 picture->draw(&mockCanvas); 91 picture->playback(&mockCanvas);
92 REPORTER_ASSERT(reporter, 2 == mockCanvas.fRects.count()); 92 REPORTER_ASSERT(reporter, 2 == mockCanvas.fRects.count());
93 REPORTER_ASSERT(reporter, rect1 == mockCanvas.fRects[0]); 93 REPORTER_ASSERT(reporter, rect1 == mockCanvas.fRects[0]);
94 REPORTER_ASSERT(reporter, rect2 == mockCanvas.fRects[1]); 94 REPORTER_ASSERT(reporter, rect2 == mockCanvas.fRects[1]);
95 } 95 }
96 // Intersect bottom right tile, but does not overlap rect 2 96 // Intersect bottom right tile, but does not overlap rect 2
97 { 97 {
98 MockCanvas mockCanvas(store); 98 MockCanvas mockCanvas(store);
99 mockCanvas.translate(-16.0f, -16.0f); 99 mockCanvas.translate(-16.0f, -16.0f);
100 picture->draw(&mockCanvas); 100 picture->playback(&mockCanvas);
101 REPORTER_ASSERT(reporter, 1 == mockCanvas.fRects.count()); 101 REPORTER_ASSERT(reporter, 1 == mockCanvas.fRects.count());
102 REPORTER_ASSERT(reporter, rect2 == mockCanvas.fRects[0]); 102 REPORTER_ASSERT(reporter, rect2 == mockCanvas.fRects[0]);
103 } 103 }
104 // Out of bounds queries, snap to border tiles 104 // Out of bounds queries, snap to border tiles
105 { 105 {
106 MockCanvas mockCanvas(store); 106 MockCanvas mockCanvas(store);
107 mockCanvas.translate(2.0f, 0.0f); 107 mockCanvas.translate(2.0f, 0.0f);
108 picture->draw(&mockCanvas); 108 picture->playback(&mockCanvas);
109 REPORTER_ASSERT(reporter, 1 == mockCanvas.fRects.count()); 109 REPORTER_ASSERT(reporter, 1 == mockCanvas.fRects.count());
110 REPORTER_ASSERT(reporter, rect1 == mockCanvas.fRects[0]); 110 REPORTER_ASSERT(reporter, rect1 == mockCanvas.fRects[0]);
111 } 111 }
112 { 112 {
113 MockCanvas mockCanvas(store); 113 MockCanvas mockCanvas(store);
114 mockCanvas.translate(0.0f, 2.0f); 114 mockCanvas.translate(0.0f, 2.0f);
115 picture->draw(&mockCanvas); 115 picture->playback(&mockCanvas);
116 REPORTER_ASSERT(reporter, 1 == mockCanvas.fRects.count()); 116 REPORTER_ASSERT(reporter, 1 == mockCanvas.fRects.count());
117 REPORTER_ASSERT(reporter, rect1 == mockCanvas.fRects[0]); 117 REPORTER_ASSERT(reporter, rect1 == mockCanvas.fRects[0]);
118 } 118 }
119 { 119 {
120 MockCanvas mockCanvas(store); 120 MockCanvas mockCanvas(store);
121 mockCanvas.translate(-22.0f, -16.0f); 121 mockCanvas.translate(-22.0f, -16.0f);
122 picture->draw(&mockCanvas); 122 picture->playback(&mockCanvas);
123 REPORTER_ASSERT(reporter, 1 == mockCanvas.fRects.count()); 123 REPORTER_ASSERT(reporter, 1 == mockCanvas.fRects.count());
124 REPORTER_ASSERT(reporter, rect2 == mockCanvas.fRects[0]); 124 REPORTER_ASSERT(reporter, rect2 == mockCanvas.fRects[0]);
125 } 125 }
126 { 126 {
127 MockCanvas mockCanvas(store); 127 MockCanvas mockCanvas(store);
128 mockCanvas.translate(-16.0f, -22.0f); 128 mockCanvas.translate(-16.0f, -22.0f);
129 picture->draw(&mockCanvas); 129 picture->playback(&mockCanvas);
130 REPORTER_ASSERT(reporter, 1 == mockCanvas.fRects.count()); 130 REPORTER_ASSERT(reporter, 1 == mockCanvas.fRects.count());
131 REPORTER_ASSERT(reporter, rect2 == mockCanvas.fRects[0]); 131 REPORTER_ASSERT(reporter, rect2 == mockCanvas.fRects[0]);
132 } 132 }
133 } 133 }
134 134
135 DEF_TEST(TileGrid_OverlapOffsetQueryAlignment, reporter) { 135 DEF_TEST(TileGrid_OverlapOffsetQueryAlignment, reporter) {
136 // Use SkTileGridPicture to generate a SkTileGrid with a helper 136 // Use SkTileGridPicture to generate a SkTileGrid with a helper
137 SkTileGridFactory::TileGridInfo info; 137 SkTileGridFactory::TileGridInfo info;
138 info.fMargin.set(1, 1); 138 info.fMargin.set(1, 1);
139 info.fOffset.set(-1, -1); 139 info.fOffset.set(-1, -1);
(...skipping 21 matching lines...) Expand all
161 tileBitmap.allocN32Pixels(10, 10); 161 tileBitmap.allocN32Pixels(10, 10);
162 SkBitmap moreThanATileBitmap; 162 SkBitmap moreThanATileBitmap;
163 moreThanATileBitmap.allocN32Pixels(11, 11); 163 moreThanATileBitmap.allocN32Pixels(11, 11);
164 SkBitmap tinyBitmap; 164 SkBitmap tinyBitmap;
165 tinyBitmap.allocN32Pixels(2, 2); 165 tinyBitmap.allocN32Pixels(2, 2);
166 // Test parts of top-left tile 166 // Test parts of top-left tile
167 { 167 {
168 // The offset should cancel the top and left borders of the top left til e 168 // The offset should cancel the top and left borders of the top left til e
169 // So a look-up at interval 0-10 should be grid aligned, 169 // So a look-up at interval 0-10 should be grid aligned,
170 MockCanvas mockCanvas(tileBitmap); 170 MockCanvas mockCanvas(tileBitmap);
171 picture->draw(&mockCanvas); 171 picture->playback(&mockCanvas);
172 REPORTER_ASSERT(reporter, 1 == mockCanvas.fRects.count()); 172 REPORTER_ASSERT(reporter, 1 == mockCanvas.fRects.count());
173 REPORTER_ASSERT(reporter, rect1 == mockCanvas.fRects[0]); 173 REPORTER_ASSERT(reporter, rect1 == mockCanvas.fRects[0]);
174 } 174 }
175 { 175 {
176 // Encroaching border by one pixel 176 // Encroaching border by one pixel
177 MockCanvas mockCanvas(moreThanATileBitmap); 177 MockCanvas mockCanvas(moreThanATileBitmap);
178 picture->draw(&mockCanvas); 178 picture->playback(&mockCanvas);
179 REPORTER_ASSERT(reporter, 2 == mockCanvas.fRects.count()); 179 REPORTER_ASSERT(reporter, 2 == mockCanvas.fRects.count());
180 REPORTER_ASSERT(reporter, rect1 == mockCanvas.fRects[0]); 180 REPORTER_ASSERT(reporter, rect1 == mockCanvas.fRects[0]);
181 REPORTER_ASSERT(reporter, rect2 == mockCanvas.fRects[1]); 181 REPORTER_ASSERT(reporter, rect2 == mockCanvas.fRects[1]);
182 } 182 }
183 { 183 {
184 // Tile stride is 8 (tileWidth - 2 * border pixels 184 // Tile stride is 8 (tileWidth - 2 * border pixels
185 // so translating by 8, should make query grid-aligned 185 // so translating by 8, should make query grid-aligned
186 // with middle tile. 186 // with middle tile.
187 MockCanvas mockCanvas(tileBitmap); 187 MockCanvas mockCanvas(tileBitmap);
188 mockCanvas.translate(SkIntToScalar(-8), SkIntToScalar(-8)); 188 mockCanvas.translate(SkIntToScalar(-8), SkIntToScalar(-8));
189 picture->draw(&mockCanvas); 189 picture->playback(&mockCanvas);
190 REPORTER_ASSERT(reporter, 1 == mockCanvas.fRects.count()); 190 REPORTER_ASSERT(reporter, 1 == mockCanvas.fRects.count());
191 REPORTER_ASSERT(reporter, rect2 == mockCanvas.fRects[0]); 191 REPORTER_ASSERT(reporter, rect2 == mockCanvas.fRects[0]);
192 } 192 }
193 { 193 {
194 MockCanvas mockCanvas(tileBitmap); 194 MockCanvas mockCanvas(tileBitmap);
195 mockCanvas.translate(-7.9f, -7.9f); 195 mockCanvas.translate(-7.9f, -7.9f);
196 picture->draw(&mockCanvas); 196 picture->playback(&mockCanvas);
197 REPORTER_ASSERT(reporter, 2 == mockCanvas.fRects.count()); 197 REPORTER_ASSERT(reporter, 2 == mockCanvas.fRects.count());
198 REPORTER_ASSERT(reporter, rect1 == mockCanvas.fRects[0]); 198 REPORTER_ASSERT(reporter, rect1 == mockCanvas.fRects[0]);
199 REPORTER_ASSERT(reporter, rect2 == mockCanvas.fRects[1]); 199 REPORTER_ASSERT(reporter, rect2 == mockCanvas.fRects[1]);
200 } 200 }
201 { 201 {
202 MockCanvas mockCanvas(tileBitmap); 202 MockCanvas mockCanvas(tileBitmap);
203 mockCanvas.translate(-8.1f, -8.1f); 203 mockCanvas.translate(-8.1f, -8.1f);
204 picture->draw(&mockCanvas); 204 picture->playback(&mockCanvas);
205 REPORTER_ASSERT(reporter, 2 == mockCanvas.fRects.count()); 205 REPORTER_ASSERT(reporter, 2 == mockCanvas.fRects.count());
206 REPORTER_ASSERT(reporter, rect2 == mockCanvas.fRects[0]); 206 REPORTER_ASSERT(reporter, rect2 == mockCanvas.fRects[0]);
207 REPORTER_ASSERT(reporter, rect3 == mockCanvas.fRects[1]); 207 REPORTER_ASSERT(reporter, rect3 == mockCanvas.fRects[1]);
208 } 208 }
209 { 209 {
210 // Regression test for crbug.com/234688 210 // Regression test for crbug.com/234688
211 // Once the 2x2 device region is inset by margin, it yields an empty 211 // Once the 2x2 device region is inset by margin, it yields an empty
212 // adjusted region, sitting right on top of the tile boundary. 212 // adjusted region, sitting right on top of the tile boundary.
213 MockCanvas mockCanvas(tinyBitmap); 213 MockCanvas mockCanvas(tinyBitmap);
214 mockCanvas.translate(-8.0f, -8.0f); 214 mockCanvas.translate(-8.0f, -8.0f);
215 picture->draw(&mockCanvas); 215 picture->playback(&mockCanvas);
216 // This test passes by not asserting. We do not validate the rects recor ded 216 // This test passes by not asserting. We do not validate the rects recor ded
217 // because the result is numerically unstable (floating point equality). 217 // because the result is numerically unstable (floating point equality).
218 // The content of any one of the four tiles of the tilegrid would be a v alid 218 // The content of any one of the four tiles of the tilegrid would be a v alid
219 // result since any bbox that covers the center point of the canvas will be 219 // result since any bbox that covers the center point of the canvas will be
220 // recorded in all four tiles. 220 // recorded in all four tiles.
221 } 221 }
222 } 222 }
223 223
224 DEF_TEST(TileGrid, reporter) { 224 DEF_TEST(TileGrid, reporter) {
225 // Out of bounds 225 // Out of bounds
(...skipping 16 matching lines...) Expand all
242 verifyTileHits(reporter, SkRect::MakeXYWH(10, 10, 1, 1), kBottomRight_Tile, 1); 242 verifyTileHits(reporter, SkRect::MakeXYWH(10, 10, 1, 1), kBottomRight_Tile, 1);
243 verifyTileHits(reporter, SkRect::MakeXYWH(17, 17, 1, 1), kBottomRight_Tile, 1); 243 verifyTileHits(reporter, SkRect::MakeXYWH(17, 17, 1, 1), kBottomRight_Tile, 1);
244 244
245 // BBoxes that overlap tiles 245 // BBoxes that overlap tiles
246 verifyTileHits(reporter, SkRect::MakeXYWH(5, 5, 10, 1), kTopLeft_Tile | kTo pRight_Tile); 246 verifyTileHits(reporter, SkRect::MakeXYWH(5, 5, 10, 1), kTopLeft_Tile | kTo pRight_Tile);
247 verifyTileHits(reporter, SkRect::MakeXYWH(5, 5, 1, 10), kTopLeft_Tile | 247 verifyTileHits(reporter, SkRect::MakeXYWH(5, 5, 1, 10), kTopLeft_Tile |
248 kBottomLeft_Tile); 248 kBottomLeft_Tile);
249 verifyTileHits(reporter, SkRect::MakeXYWH(5, 5, 10, 10), kAll_Tile); 249 verifyTileHits(reporter, SkRect::MakeXYWH(5, 5, 10, 10), kAll_Tile);
250 verifyTileHits(reporter, SkRect::MakeXYWH(-10, -10, 40, 40), kAll_Tile); 250 verifyTileHits(reporter, SkRect::MakeXYWH(-10, -10, 40, 40), kAll_Tile);
251 } 251 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698