Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 540963002: Change SkPicture::draw to playback (Closed)

Created:
6 years, 3 months ago by robertphillips
Modified:
6 years, 3 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix nanomsg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -81 lines) Patch
M bench/PicturePlaybackBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/SKPBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/nanobench.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M debugger/SkDebugger.cpp View 1 chunk +1 line, -1 line 0 comments Download
M dm/DMPDFTask.cpp View 1 chunk +1 line, -1 line 0 comments Download
M dm/DMQuiltTask.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M experimental/nanomsg/picture_demo.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M gm/distantclip.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M gm/gmmain.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/optimizations.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M gyp/skia_for_android_framework_defines.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/skia_for_chromium_defines.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkPicture.h View 1 1 chunk +12 lines, -2 lines 0 comments Download
M samplecode/SampleAll.cpp View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleApp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SamplePictFile.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M src/core/SkCanvas.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkPicture.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkPictureRecorder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/PathOpsSkpClipTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/PictureTest.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M tests/SerializationTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/TileGridTest.cpp View 8 chunks +14 lines, -14 lines 0 comments Download
M tools/PictureRenderer.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/bench_pictures_main.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/bench_playback.cpp View 3 chunks +8 lines, -8 lines 0 comments Download
M tools/bench_record.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dump_record.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/filtermain.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/gpuveto.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/render_pictures_main.cpp View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
robertphillips
6 years, 3 months ago (2014-09-04 15:08:30 UTC) #2
reed1
lgtm + bikeshed on the callback name https://codereview.chromium.org/540963002/diff/1/include/core/SkPicture.h File include/core/SkPicture.h (right): https://codereview.chromium.org/540963002/diff/1/include/core/SkPicture.h#newcode121 include/core/SkPicture.h:121: void playback(SkCanvas* ...
6 years, 3 months ago (2014-09-04 15:13:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/540963002/1
6 years, 3 months ago (2014-09-04 15:22:38 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot on tryserver.skia (http://108.170.220.120:10117/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot/builds/553)
6 years, 3 months ago (2014-09-04 15:27:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/540963002/20001
6 years, 3 months ago (2014-09-04 15:35:43 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-04 15:42:58 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as c5ba71d2e5cd426def66fa49dcf003e5b2c98dc7

Powered by Google App Engine
This is Rietveld 408576698