Restart in Desktop if Metro tries to start up without GPU

Restart in Desktop if Metro tries to start up without GPU

This doesn't yet handle the case where the GPU becomes crashy. The
user would need to close and re-open Chrome, currently. That case
seems more complicated to handle because it's only down low that
we know that, not up at the chrome:: level.

This DCHECKs in https://code.google.com/p/chromium/codesearch#chromium/src/base/win/scoped_com_initializer.h&l=55
in debug, but I believe that's an unrelated problem at HEAD. (i.e. all
restarts are doing that currently.)

R=cpu@chromium.org
BUG=308736
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232836

[scottmg, 2013-11-03 22:01:07]

As noted in description, this only handles "gpu is disabled at launch time". I
can try and address the "gpu becomes crashy later" case as  a subsequent CL if
we think it's worth spending the time on.

[wiltzius, 2013-11-04 18:44:46]

On 2013/11/03 22:01:07, scottmg wrote:
> As noted in description, this only handles "gpu is disabled at launch time". I
> can try and address the "gpu becomes crashy later" case as  a subsequent CL if
> we think it's worth spending the time on.

Scott this handles the settings page change case because that requires a Chrome
restart, right? That one + hardware changes are the most worrying, as long as
Chrome sort-of works at least people could launch Chrome then restart in desktop
mode for the "becomes crashy later" case.

[cpu_(ooo_6.6-7.5), 2013-11-04 19:17:02]

lgtm

https://codereview.chromium.org/54093007/diff/50001/chrome/browser/metro_view...
File chrome/browser/metro_viewer/chrome_metro_viewer_process_host_aurawin.cc
(right):

https://codereview.chromium.org/54093007/diff/50001/chrome/browser/metro_view...
chrome/browser/metro_viewer/chrome_metro_viewer_process_host_aurawin.cc:7:
#include <atlbase.h>
please no ATL. Does our LOG() not work in this case? or you can use
OutputdebugStringA.

[scottmg, 2013-11-04 23:05:44]

https://codereview.chromium.org/54093007/diff/50001/chrome/browser/metro_view...
File chrome/browser/metro_viewer/chrome_metro_viewer_process_host_aurawin.cc
(right):

https://codereview.chromium.org/54093007/diff/50001/chrome/browser/metro_view...
chrome/browser/metro_viewer/chrome_metro_viewer_process_host_aurawin.cc:7:
#include <atlbase.h>
On 2013/11/04 19:17:02, cpu wrote:
> please no ATL. Does our LOG() not work in this case? or you can use
> OutputdebugStringA.

Done.

[scottmg, 2013-11-04 23:45:00]

Committed patchset #4 manually as r232836 (presubmit successful).