Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 540913003: mojo: Java bindings: Add name to the manager. (Closed)

Created:
6 years, 3 months ago by qsr
Modified:
6 years, 3 months ago
Reviewers:
ppi
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

mojo: Java bindings: Add name to the manager. The name is used to retrieve a service from a ServiceProvider. R=ppi@chromium.org Committed: https://crrev.com/5a02c9d2dbb7c109acdcf6ece79f23f3362da5b8 Cr-Commit-Position: refs/heads/master@{#293499}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Follow review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -70 lines) Patch
M mojo/android/javatests/src/org/chromium/mojo/bindings/InterfacesTest.java View 1 chunk +5 lines, -0 lines 0 comments Download
M mojo/public/java/bindings/src/org/chromium/mojo/bindings/Interface.java View 1 1 chunk +6 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/generators/java_templates/interface_definition.tmpl View 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/generators/mojom_java_generator.py View 1 13 chunks +70 lines, -70 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
qsr
6 years, 3 months ago (2014-09-04 15:25:34 UTC) #1
ppi
lgtm % nits https://codereview.chromium.org/540913003/diff/1/mojo/public/java/bindings/src/org/chromium/mojo/bindings/Interface.java File mojo/public/java/bindings/src/org/chromium/mojo/bindings/Interface.java (right): https://codereview.chromium.org/540913003/diff/1/mojo/public/java/bindings/src/org/chromium/mojo/bindings/Interface.java#newcode177 mojo/public/java/bindings/src/org/chromium/mojo/bindings/Interface.java:177: * Returns the name of the ...
6 years, 3 months ago (2014-09-04 15:32:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/540913003/20001
6 years, 3 months ago (2014-09-04 15:42:54 UTC) #4
qsr
https://codereview.chromium.org/540913003/diff/1/mojo/public/java/bindings/src/org/chromium/mojo/bindings/Interface.java File mojo/public/java/bindings/src/org/chromium/mojo/bindings/Interface.java (right): https://codereview.chromium.org/540913003/diff/1/mojo/public/java/bindings/src/org/chromium/mojo/bindings/Interface.java#newcode177 mojo/public/java/bindings/src/org/chromium/mojo/bindings/Interface.java:177: * Returns the name of the interface. Used by ...
6 years, 3 months ago (2014-09-04 15:48:21 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_triggered_tests/builds/53531) win_chromium_x64_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_swarming/builds/5926)
6 years, 3 months ago (2014-09-04 16:45:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/540913003/20001
6 years, 3 months ago (2014-09-05 08:19:30 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 9f100b6a0a028c9320b572741d977d4ac528c8b0
6 years, 3 months ago (2014-09-05 10:47:56 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:38:47 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/5a02c9d2dbb7c109acdcf6ece79f23f3362da5b8
Cr-Commit-Position: refs/heads/master@{#293499}

Powered by Google App Engine
This is Rietveld 408576698