Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 540883002: Make base::internal::CallbackBase::is_null inline. (Closed)

Created:
6 years, 3 months ago by Adam Rice
Modified:
6 years, 3 months ago
Reviewers:
Nico, Elliot Glaysher, piman
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make base::internal::CallbackBase::is_null inline. This saves 11 bytes per call site on x64-clang and 12 byte per call site on ARM-gcc. BUG=410776 TEST=base_unittests Committed: https://crrev.com/caf874447fabaaee90921d611a052648ea150c70 Cr-Commit-Position: refs/heads/master@{#295215}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M base/callback_internal.h View 1 chunk +1 line, -1 line 0 comments Download
M base/callback_internal.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Elliot Glaysher
not an owner, but as the person who usually waves the don't-inline-things flag, this looks ...
6 years, 3 months ago (2014-09-04 17:02:54 UTC) #2
piman
On 2014/09/04 17:02:54, Elliot Glaysher wrote: > not an owner, but as the person who ...
6 years, 3 months ago (2014-09-05 17:55:21 UTC) #3
Adam Rice
+thakis for base/ OWNERS.
6 years, 3 months ago (2014-09-08 04:25:21 UTC) #5
Adam Rice
ping
6 years, 3 months ago (2014-09-16 12:09:43 UTC) #6
Nico
lgtm Sorry, I wasn't aware that you needed something from me here. (Also, when pinging, ...
6 years, 3 months ago (2014-09-16 14:51:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/540883002/1
6 years, 3 months ago (2014-09-17 01:11:42 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as 6ee276ae6d801d9a0015385d41c9ba21418aa595
6 years, 3 months ago (2014-09-17 02:13:01 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-17 02:13:36 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/caf874447fabaaee90921d611a052648ea150c70
Cr-Commit-Position: refs/heads/master@{#295215}

Powered by Google App Engine
This is Rietveld 408576698