Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1389)

Issue 540873002: Provide feedback when list item are activated. (Closed)

Created:
6 years, 3 months ago by fukino
Modified:
6 years, 3 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Provide feedback when list item are activated. This CL provides touch-operation users with feedback earlier. Menu items will be colored blue on touchstart. Scrollable items (in directory tree and file list) will be colored gray on touchstart. We don't use blue for them because touching them doesn't mean selecting them. (Users may have started scrolling) BUG=404540 TEST=manually Committed: https://crrev.com/5e178f4ddebd8cb018d8e4cf64dbb8132690add9 Cr-Commit-Position: refs/heads/master@{#293702}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove style specification for navigation-list. #

Patch Set 3 : Remove one more style for navigation-list. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -66 lines) Patch
M ui/file_manager/file_manager/foreground/css/common.css View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/css/file_manager.css View 1 2 4 chunks +4 lines, -65 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
fukino
@hirono, PTAL the CL? Thanks!
6 years, 3 months ago (2014-09-04 11:36:43 UTC) #2
hirono
Sorry for late. https://codereview.chromium.org/540873002/diff/1/ui/file_manager/file_manager/foreground/css/file_manager.css File ui/file_manager/file_manager/foreground/css/file_manager.css (right): https://codereview.chromium.org/540873002/diff/1/ui/file_manager/file_manager/foreground/css/file_manager.css#newcode210 ui/file_manager/file_manager/foreground/css/file_manager.css:210: background-color: rgb(225, 225, 225); How about ...
6 years, 3 months ago (2014-09-05 06:30:35 UTC) #3
fukino
https://codereview.chromium.org/540873002/diff/1/ui/file_manager/file_manager/foreground/css/file_manager.css File ui/file_manager/file_manager/foreground/css/file_manager.css (right): https://codereview.chromium.org/540873002/diff/1/ui/file_manager/file_manager/foreground/css/file_manager.css#newcode210 ui/file_manager/file_manager/foreground/css/file_manager.css:210: background-color: rgb(225, 225, 225); On 2014/09/05 06:30:35, hirono wrote: ...
6 years, 3 months ago (2014-09-05 06:43:45 UTC) #4
fukino
On 2014/09/05 06:43:45, fukino wrote: > https://codereview.chromium.org/540873002/diff/1/ui/file_manager/file_manager/foreground/css/file_manager.css > File ui/file_manager/file_manager/foreground/css/file_manager.css (right): > > https://codereview.chromium.org/540873002/diff/1/ui/file_manager/file_manager/foreground/css/file_manager.css#newcode210 > ...
6 years, 3 months ago (2014-09-08 09:12:48 UTC) #5
hirono
On 2014/09/08 09:12:48, fukino wrote: > On 2014/09/05 06:43:45, fukino wrote: > > > https://codereview.chromium.org/540873002/diff/1/ui/file_manager/file_manager/foreground/css/file_manager.css ...
6 years, 3 months ago (2014-09-08 09:20:53 UTC) #6
fukino
On 2014/09/08 09:20:53, hirono wrote: > On 2014/09/08 09:12:48, fukino wrote: > > On 2014/09/05 ...
6 years, 3 months ago (2014-09-08 09:21:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fukino@chromium.org/540873002/40001
6 years, 3 months ago (2014-09-08 09:23:31 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 8b85f0597c3910ebb9165f632a5a23e49245472a
6 years, 3 months ago (2014-09-08 10:21:37 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:45:35 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5e178f4ddebd8cb018d8e4cf64dbb8132690add9
Cr-Commit-Position: refs/heads/master@{#293702}

Powered by Google App Engine
This is Rietveld 408576698