Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 540853003: Rename HTMLMediaElement::closeCaptionTracksChanged to textTracksChanged (Closed)

Created:
6 years, 3 months ago by fs
Modified:
6 years, 3 months ago
CC:
blink-reviews, blink-reviews-html_chromium.org, philipj_slow, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, nessy, vcarbune.chromium
Project:
blink
Visibility:
Public.

Description

Rename HTMLMediaElement::closeCaptionTracksChanged to textTracksChanged The name closeCaptionTracksChanged() is slightly misleading since this method is called for all kinds of (text) tracks, and not just 'caption' tracks (and the 'closed' needn't necessarily apply either...) Rename to textTracksChanged() since that more accurately describe what it does. Also replace a few "manual" instances of textTracksChanged() with calls to the method. In the case of HTMLMediaElement::didAddTrackElement, it can be dropped altogether because addTextTrack already calls it (and scheduleDelayedAction(LoadTextTrackResource) does not have side-effects that would affect the result.) Also do the same name-change for the closedCaptionTracksChanged() notifier on MediaControls (same semantic meaning.) Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181401

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -13 lines) Patch
M Source/core/html/HTMLMediaElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 5 chunks +6 lines, -10 lines 0 comments Download
M Source/core/html/shadow/MediaControls.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/shadow/MediaControls.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
fs
6 years, 3 months ago (2014-09-04 13:08:14 UTC) #2
philipj_slow
lgtm
6 years, 3 months ago (2014-09-04 13:35:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/540853003/1
6 years, 3 months ago (2014-09-04 13:35:59 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-04 21:38:12 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181401

Powered by Google App Engine
This is Rietveld 408576698