Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 540853002: Remove focus on back key press if focus is on url bar. (Closed)

Created:
6 years, 3 months ago by ankit
Modified:
6 years, 3 months ago
Reviewers:
Ted C
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove focus on back key press if focus is on url bar. Handlind back key event and clearing focus of url bar and retaining focus to content view. BUG= Committed: https://crrev.com/13458a610287e016ea10a0b56d1de406816cfec9 Cr-Commit-Position: refs/heads/master@{#294105}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Modified code as suggested. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M content/shell/android/java/src/org/chromium/content_shell/Shell.java View 1 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
ankit
@Ted PTAL
6 years, 3 months ago (2014-09-04 10:40:08 UTC) #2
ankit
On 2014/09/04 10:40:08, ankit wrote: > @Ted > PTAL @Ted PTAL
6 years, 3 months ago (2014-09-08 09:56:48 UTC) #3
Ted C
https://codereview.chromium.org/540853002/diff/1/content/shell/android/java/src/org/chromium/content_shell/Shell.java File content/shell/android/java/src/org/chromium/content_shell/Shell.java (right): https://codereview.chromium.org/540853002/diff/1/content/shell/android/java/src/org/chromium/content_shell/Shell.java#newcode174 content/shell/android/java/src/org/chromium/content_shell/Shell.java:174: mContentViewCore.getContainerView().requestFocus(); Is the above line necessary with this line? ...
6 years, 3 months ago (2014-09-08 15:47:55 UTC) #4
ankit
@Ted I have incorporated review comment. PTAL new patch. https://codereview.chromium.org/540853002/diff/1/content/shell/android/java/src/org/chromium/content_shell/Shell.java File content/shell/android/java/src/org/chromium/content_shell/Shell.java (right): https://codereview.chromium.org/540853002/diff/1/content/shell/android/java/src/org/chromium/content_shell/Shell.java#newcode174 content/shell/android/java/src/org/chromium/content_shell/Shell.java:174: ...
6 years, 3 months ago (2014-09-09 10:28:35 UTC) #5
Ted C
lgtm
6 years, 3 months ago (2014-09-09 17:29:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ankit2.kumar@samsung.com/540853002/20001
6 years, 3 months ago (2014-09-10 03:39:04 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 1e7397115db64243c78928ec03e38416c790de50
6 years, 3 months ago (2014-09-10 05:00:51 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 05:08:42 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/13458a610287e016ea10a0b56d1de406816cfec9
Cr-Commit-Position: refs/heads/master@{#294105}

Powered by Google App Engine
This is Rietveld 408576698