LayoutTests/http/tests/serviceworker/getregistration.html - Issue 540823003: ServiceWorker: Implement navigator.serviceWorker.getRegistration [3/3]

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/http/tests/serviceworker/getregistration.html

Issue 540823003: ServiceWorker: Implement navigator.serviceWorker.getRegistration [3/3] (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: patch for review Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../resources/testharness.js"></script>

	3 <script src="../resources/testharnessreport.js"></script>

	4 <script src="resources/test-helpers.js"></script>

	5 <script>

	6 async_test(function(t) {

	7 var documentURL = 'no-such-worker';

	8 navigator.serviceWorker.getRegistration(documentURL)

	9 .then(function(value) {

	10 assert_equals(value, undefined,

	11 'getRegistration should resolve with undefined');

	12 t.done();

	13 })

	14 .catch(unreached_rejection(t));

	15 }, 'getRegistration');

	16

	17 async_test(function(t) {

	18 var scope = 'scope/worker/';

	19 var registration;

	20 navigator.serviceWorker.register('resources/empty-worker.js',

	21 {scope: scope})

	22 .then(function(r) {

	23 registration = r;

	24 return navigator.serviceWorker.getRegistration(scope);

	25 })

	26 .then(function(value) {

	27 assert_equals(value, registration,

	28 'getRegistration should resolve with registration');

	29 t.done();

	30 })

	31 .catch(unreached_rejection(t));

	32 }, 'Register then getRegistration');

	33
	nhiroki 2014/09/10 07:45:04 How about testing following cases? - getRegistrat How about testing following cases? - getRegistration() without a doc url argument - getRegistration() with a cross origin url - register() -> unregister() -> getRegistration() (should return 'undefined') Kunihiko Sakamoto 2014/09/10 09:34:51 Thanks for the test cases suggestion! Done. Show quoted text On 2014/09/10 07:45:04, nhiroki wrote: > How about testing following cases? > > - getRegistration() without a doc url argument > - getRegistration() with a cross origin url > - register() -> unregister() -> getRegistration() (should return 'undefined') Thanks for the test cases suggestion! Done.
	34 </script>

OLD	NEW

« no previous file with comments | « no previous file | Source/modules/serviceworkers/ServiceWorkerContainer.h » ('j') | Source/modules/serviceworkers/ServiceWorkerContainer.cpp » ('J')