Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 540713002: Cast: Get rid of frame_id_map (Closed)

Created:
6 years, 3 months ago by hubbe
Modified:
6 years, 3 months ago
Reviewers:
Alpha Left Google
CC:
chromium-reviews, hclam+watch_chromium.org, cbentzel+watch_chromium.org, imcheng+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, pwestin+watch_google.com, feature-media-reviews_chromium.org, miu+watch_chromium.org, hubbe+watch_chromium.org, mikhal+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cast: Get rid of frame_id_map FrameBuffer is basically a superset of FrameInfo, so let's merge FrameIdMap with Framer and use FrameBuffer instead of FrameInfo. No functional changes, only refactoring. Committed: https://crrev.com/66cd59f4a4efaba086795c8613c945f0c64f7183 Cr-Commit-Position: refs/heads/master@{#293575}

Patch Set 1 #

Patch Set 2 : removed unused variable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+269 lines, -396 lines) Patch
M media/cast/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M media/cast/cast.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M media/cast/net/rtp/cast_message_builder.h View 3 chunks +4 lines, -4 lines 0 comments Download
M media/cast/net/rtp/cast_message_builder.cc View 7 chunks +10 lines, -9 lines 0 comments Download
M media/cast/net/rtp/cast_message_builder_unittest.cc View 9 chunks +18 lines, -11 lines 0 comments Download
M media/cast/net/rtp/frame_buffer.h View 2 chunks +5 lines, -2 lines 0 comments Download
M media/cast/net/rtp/frame_buffer.cc View 5 chunks +29 lines, -3 lines 0 comments Download
D media/cast/net/rtp/frame_id_map.h View 1 chunk +0 lines, -90 lines 0 comments Download
D media/cast/net/rtp/frame_id_map.cc View 1 chunk +0 lines, -247 lines 0 comments Download
M media/cast/net/rtp/framer.h View 1 2 chunks +24 lines, -3 lines 0 comments Download
M media/cast/net/rtp/framer.cc View 1 5 chunks +179 lines, -23 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
hubbe
6 years, 3 months ago (2014-09-04 00:28:01 UTC) #2
Alpha Left Google
On 2014/09/04 00:28:01, hubbe wrote: LGTM.
6 years, 3 months ago (2014-09-04 19:26:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hubbe@chromium.org/540713002/1
6 years, 3 months ago (2014-09-04 21:41:16 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/12539)
6 years, 3 months ago (2014-09-05 00:29:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hubbe@chromium.org/540713002/20001
6 years, 3 months ago (2014-09-05 20:03:39 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 08499cc3c48f6748b5fa490958f6fb10c252cf77
6 years, 3 months ago (2014-09-05 20:50:35 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:41:24 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/66cd59f4a4efaba086795c8613c945f0c64f7183
Cr-Commit-Position: refs/heads/master@{#293575}

Powered by Google App Engine
This is Rietveld 408576698