Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 540693002: Only enumerate known WinUSB devices using chrome.usb, to avoid errors (Closed)

Created:
6 years, 3 months ago by juanlang (chromium.org)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Only enumerate known WinUSB devices using chrome.usb, to avoid errors attempting to open HID devices using libusb. BUG=410623 Committed: https://crrev.com/073b9b87cee7317f880b656077fd488b62dcdc32 Cr-Commit-Position: refs/heads/master@{#293306}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M chrome/browser/resources/cryptotoken/usbgnubbydevice.js View 1 chunk +11 lines, -8 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
Reilly Grant (use Gerrit)
lgtm
6 years, 3 months ago (2014-09-04 00:40:10 UTC) #2
xiyuan
lgtm
6 years, 3 months ago (2014-09-04 00:43:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/juanlang@chromium.org/540693002/1
6 years, 3 months ago (2014-09-04 00:53:43 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/1933)
6 years, 3 months ago (2014-09-04 02:58:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/juanlang@chromium.org/540693002/1
6 years, 3 months ago (2014-09-04 03:00:42 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/1974)
6 years, 3 months ago (2014-09-04 03:42:51 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/juanlang@chromium.org/540693002/1
6 years, 3 months ago (2014-09-04 15:44:29 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1) as daf6a4483530e290d08f1cbfbb1573787a390d30
6 years, 3 months ago (2014-09-04 16:16:10 UTC) #15
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:31:43 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/073b9b87cee7317f880b656077fd488b62dcdc32
Cr-Commit-Position: refs/heads/master@{#293306}

Powered by Google App Engine
This is Rietveld 408576698